Skip to contentSkip to conversation

OMAP1: AMS_DELTA: Fix DSP public peripherals support

PATCH Superseded Janusz Krzysztofik 2 participants 6 messages Oct 22, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP1: AMS_DELTA: Fix DSP public peripherals support

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?) machines as long as old dspgateway code were present in the l-o tree. For several months it is no longer included, breaking support for McBSP1 based audio on Amstrad Delta, for example.

This patch, derived from the old dspgateway code, corrects the problem for the board by simply taking the DSP out of reset state, I guess. That way, things should not break when a new dsp code is added to the tree, and the change can be reverted then.

If there are any reports on McBSP1 or other DSP public peripherals not working for other OMAP1 machines (I've not heard of any for now), I can prepare a more general patch providing an extra include file with a helper function defined.

Created and tested against linux-2.6.32-rc5

---
--- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig 2009-10-22
00:55:49.000000000 +0200
+++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c 2009-10-22
01:46:39.000000000 +0200
@@ -235,6 +235,8 @@ static void __init ams_delta_init(void)

omap_usb_init(&ams_delta_usb_config); platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
+
+ omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
}

static struct plat_serial8250_port ams_delta_modem_ports[] = {

#1 lore raw

PATCH RESEND 1/1 OMAP1: AMS_DELTA: Fix DSP public peripherals support

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?) machines as long as old dspgateway code were present in the l-o tree. For several months it is no longer included, breaking support for McBSP1 based audio on Amstrad Delta, for example.

This patch, derived from the old dspgateway code, corrects the problem for the board by simply taking the DSP out of reset state, I guess. That way, things should not break when a new dsp code is added to the tree, and the change can be reverted then.

If there are any reports on McBSP1 or other DSP public peripherals not working for other OMAP1 machines (I've not heard of any for now), I can prepare a more general patch providing an extra include file with a helper function defined.

Created and tested against linux-2.6.32-rc5

---

Quoted 4 lines · Thursday 22 October 2009 02:22:53 Janusz Krzysztofik wrote:

--- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig 2009-10-22
00:55:49.000000000 +0200
+++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c 2009-10-22
01:46:39.000000000 +0200

Tony,
The above lines has been mangled by my mailer, that's why I resend for your convenience.

arch/arm/mach-omap1/board-ams-delta.c renamed from arch/arm/mach-omap1/board-ams-delta.c.orig +2 -0
@@ -235,6 +235,8 @@ static void __init ams_delta_init(void)
 
 	omap_usb_init(&ams_delta_usb_config);
 	platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
+
+	omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
 }
 
 static struct plat_serial8250_port ams_delta_modem_ports[] = {
reviewer
#2 lore raw
Quoted 5 lines · Janusz Krzysztofik

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?) machines as long as old dspgateway code were present in the l-o tree. For several months it is no longer included, breaking support for McBSP1 based audio on Amstrad Delta, for example.

Quoted 8 lines

This patch, derived from the old dspgateway code, corrects the problem for the board by simply taking the DSP out of reset state, I guess. That way, things should not break when a new dsp code is added to the tree, and the change can be reverted then.

If there are any reports on McBSP1 or other DSP public peripherals not working for other OMAP1 machines (I've not heard of any for now), I can prepare a more general patch providing an extra include file with a helper function defined.

Seems like a good fix. Of course it would be nice to also idle the DSP for some power savings, but maybe we can add something for that this coming merge window.

Regards,

Tony

Quoted 26 lines

Created and tested against linux-2.6.32-rc5

---

Quoted 4 lines · Thursday 22 October 2009 02:22:53 Janusz Krzysztofik wrote:

--- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig 2009-10-22
00:55:49.000000000 +0200
+++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c 2009-10-22
01:46:39.000000000 +0200

Tony,
The above lines has been mangled by my mailer, that's why I resend for your convenience.

arch/arm/mach-omap1/board-ams-delta.c renamed from arch/arm/mach-omap1/board-ams-delta.c.orig +2 -0
@@ -235,6 +235,8 @@ static void __init ams_delta_init(void)
 
 	omap_usb_init(&ams_delta_usb_config);
 	platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
+
+	omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
 }
 
 static struct plat_serial8250_port ams_delta_modem_ports[] = {
#3 lore raw

Thursday 22 October 2009 20:06:59 Tony Lindgren napisał(a):

Quoted 6 lines · Janusz Krzysztofik
Quoted 5 lines

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?) machines as long as old dspgateway code were present in the l-o tree. For several months it is no longer included, breaking support for McBSP1 based audio on Amstrad Delta, for example.

Quoted 6 lines
Quoted 4 lines

This patch, derived from the old dspgateway code, corrects the problem for the board by simply taking the DSP out of reset state, I guess. That way, things should not break when a new dsp code is added to the tree, and the change can be reverted then.

Seems like a good fix.

Tony,
Does it mean that you can push it as a fix for 2.6.32? That would be great if my successfull efforts on getting audio support for Amstrad Delta included in the mainline tree would result in a fully functional solution!

I start preparing a new ams_delta_defconfig then.

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

reviewer
#4 lore raw
Quoted 12 lines · Janusz Krzysztofik

Thursday 22 October 2009 20:06:59 Tony Lindgren napisał(a):

Quoted 11 lines · Janusz Krzysztofik
Quoted 9 lines

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?) machines as long as old dspgateway code were present in the l-o tree. For several months it is no longer included, breaking support for McBSP1 based audio on Amstrad Delta, for example.

This patch, derived from the old dspgateway code, corrects the problem for the board by simply taking the DSP out of reset state, I guess. That way, things should not break when a new dsp code is added to the tree, and the change can be reverted then.

Quoted 4 lines
Quoted 1 line

Seems like a good fix.

Tony,
Does it mean that you can push it as a fix for 2.6.32? That would be great if my successfull efforts on getting audio support for Amstrad Delta included in the mainline tree would result in a fully functional solution!

Yeah we should be able to merge those as fixes.

Quoted 1 line

I start preparing a new ams_delta_defconfig then.

Cool :)

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

reviewer
#5 lore raw

PATCH RESEND 1/1 OMAP1: AMS_DELTA: Fix DSP public peripherals support

In reply to Janusz Krzysztofik

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): e672f57540ddd030f52aa14a03aa5745e97da406

PatchWorks
http://patchwork.kernel.org/patch/55312/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e672f57540ddd030f52aa14a03aa5745e97da406