Skip to contentSkip to conversation

omap mailbox: remove disable_/enable_mbox_irq in isr

PATCH In review C.A, Subramaniam 2 participants 2 messages Sep 22, 2009 – Nov 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/10 omap mailbox: remove disable_/enable_mbox_irq in isr

Quoted 1 line

From d9bcb084bfdfdd72a4b449ca4c5990c27e8f6957 Mon Sep 17 00:00:00 2001

From: Hiroshi DOYU <[email protected]>
Date: Wed, 2 Sep 2009 20:06:38 +0530
Subject: [PATCH 5/10] omap mailbox: remove disable_/enable_mbox_irq in isr

No need to handle it in isr, since irq won't happen during isr.

---
 arch/arm/plat-omap/mailbox.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
arch/arm/plat-omap/mailbox.c +0 -3
index 6e713a7..8a6d087 100644
@@ -209,8 +209,6 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox)
 	mbox_msg_t msg;
 	struct request_queue *q = mbox->rxq->queue;
 
-	disable_mbox_irq(mbox, IRQ_RX);
-
 	while (!mbox_fifo_empty(mbox)) {
 		rq = blk_get_request(q, WRITE, GFP_ATOMIC);
 		if (unlikely(!rq))
@@ -226,7 +224,6 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox)
 
 	/* no more messages in the fifo. clear IRQ source. */
 	ack_mbox_irq(mbox, IRQ_RX);
-	enable_mbox_irq(mbox, IRQ_RX);
 nomem:
 	schedule_work(&mbox->rxq->work);
 }
Signature · 1 line
1.5.3.2
#1 lore raw

PATCH 5/10 omap mailbox: remove disable_/enable_mbox_irq in isr

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: for-next

Initial commit ID (Likely to change): 5219cbeee4a15eaf6c56c5e3fc2610b230d4c99f

PatchWorks
http://patchwork.kernel.org/patch/49313/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=5219cbeee4a15eaf6c56c5e3fc2610b230d4c99f