Skip to contentSkip to conversation

cbus: fix comilation breakage

PATCH In review Alexander Shishkin 3 participants 3 messages Apr 21, 2010 – Apr 22, 2010

lore
Share & tools
lore

Alexander Shishkin

author
#0 lore raw

PATCH 1/1 cbus: fix comilation breakage

Just tried to build n8x0_defconfig on the current master and got cbus failing to compile due to implicit kzalloc() (and others from slab.h) references. I'm not sure that including slab.h directly is the right thing to do here, though.

Signed-off-by Alexander Shishkin <[email protected]>
---
 drivers/cbus/cbus.c         |    1 +
 drivers/cbus/retu-headset.c |    1 +
 drivers/cbus/retu-user.c    |    1 +
 drivers/cbus/retu-wdt.c     |    1 +
 drivers/cbus/tahvo-user.c   |    1 +
 5 files changed, 5 insertions(+), 0 deletions(-)
drivers/cbus/cbus.c +1 -0
index 00c3c32..18260f2 100644
@@ -26,6 +26,7 @@
 #include <linux/device.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/spinlock.h>
 #include <linux/gpio.h>
drivers/cbus/retu-headset.c +1 -0
index e798bc2..c38abf1 100644
@@ -22,6 +22,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/input.h>
 #include <linux/platform_device.h>
drivers/cbus/retu-user.c +1 -0
index 0f35dc5..1a29492 100644
@@ -23,6 +23,7 @@
 
 #include <linux/types.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/init.h>
drivers/cbus/retu-wdt.c +1 -0
index 35932dd..79585d8 100644
@@ -22,6 +22,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/init.h>
drivers/cbus/tahvo-user.c +1 -0
index c0e8daf..01e7f20 100644
@@ -23,6 +23,7 @@
 
 #include <linux/types.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/init.h>
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 6 lines · Alexander Shishkin

Just tried to build n8x0_defconfig on the current master and got cbus failing to compile due to implicit kzalloc() (and others from slab.h) references. I'm not sure that including slab.h directly is the right thing to do here, though.

Signed-off-by Alexander Shishkin <[email protected]>

Yep, hit the same problem here, this patch fixes the build.

- Paul

#2 lore raw

PATCH 1/1 cbus: fix comilation breakage

In reply to Alexander Shishkin

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: cbus

Initial commit ID (Likely to change): 79b8b733f926a38ef8dc2f62a5aa5e9708f5deef

PatchWorks
http://patchwork.kernel.org/patch/93871/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=79b8b733f926a38ef8dc2f62a5aa5e9708f5deef