Skip to contentSkip to conversation

omap: Stalker board: switch over to gpio_set_debounce

PATCH New Santosh Shilimkar 2 participants 2 messages May 29, 2010 – May 31, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 omap: Stalker board: switch over to gpio_set_debounce

With latest linus's tip, omap3_defconfig is broken.

LD init/built-in.o
LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `ads7846_dev_init':
linux-2.6/arch/arm/mach-omap2/board-omap3stalker.c:542: undefined reference to omap_set_gpio_debounce' linux-2.6/arch/arm/mach-omap2/board-omap3stalker.c:543: undefined reference to omap_set_gpio_debounce_time'
make: *** [.tmp_vmlinux1] Error 1

Quoted 1 line

From the commit 48feb337475a ( arm: omap: switch over to gpio_set_debounce),

board-omap3stalker.c seems to be missed out or got merged later. The patch was to remove omap-specific implementations for gpio debouncing in favor of gpiolib function.

Cc Felipe Balbi <[email protected]>
Cc Kevin Hilman <[email protected]>

---
Updated the subject and changelog as suggested by Kevin Hilman

 arch/arm/mach-omap2/board-omap3stalker.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/arm/mach-omap2/board-omap3stalker.c +1 -3
index f848ba8..a04cffd 100644
@@ -538,9 +538,7 @@ static void ads7846_dev_init(void)
 		printk(KERN_ERR "can't get ads7846 pen down GPIO\n");
 
 	gpio_direction_input(OMAP3_STALKER_TS_GPIO);
-
-	omap_set_gpio_debounce(OMAP3_STALKER_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_STALKER_TS_GPIO, 0xa);
+	gpio_set_debounce(OMAP3_STALKER_TS_GPIO, 310);
 }
 
 static int ads7846_get_pendown_state(void)
Signature · 1 line
1.6.0.4
maintainer
#1 lore raw

PATCH v2 1/1 omap: Stalker board: switch over to gpio_set_debounce

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 34ebd9a47caa9f4fc7bb28a08b89f712f409e55c

PatchWorks
http://patchwork.kernel.org/patch/103017/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=34ebd9a47caa9f4fc7bb28a08b89f712f409e55c