Skip to contentSkip to conversation

omap3: id: fix 3630 rev detection

PATCH New Nishanth Menon 2 participants 2 messages Aug 5, 2010 – Aug 10, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap3: id: fix 3630 rev detection

Wrong placement of break causes all revisions of 3630 to be detected as 3630 es1.2, we need to break main loop if we have an identified chip, default falls through as in the rest of the switches in this function.

Cc Paul Walmsley <[email protected]>
Cc Sanjeev Premi <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Manjunath K <[email protected]>
Cc Anand Gadiyar <[email protected]>
Cc Felipe Balbi <[email protected]>
---
 arch/arm/mach-omap2/id.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/id.c +1 -1
index e8256a2..9a879f9 100644
@@ -284,8 +284,8 @@ static void __init omap3_check_revision(void)
 		default:
 			omap_revision =  OMAP3630_REV_ES1_2;
 			omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
-			break;
 		}
+		break;
 	default:
 		/* Unknown default to latest silicon rev as default*/
 		omap_revision =  OMAP3630_REV_ES1_2;
Signature · 1 line
1.6.3.3
maintainer
#1 lore raw

PATCH 1/1 omap3: id: fix 3630 rev detection

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 5c61cf9fcab4ff75af9403bb378e772b74e4ddd1

PatchWorks
http://patchwork.kernel.org/patch/117282/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=5c61cf9fcab4ff75af9403bb378e772b74e4ddd1