Skip to contentSkip to conversation

OMAP4: enable smc instruction in new assembler versions

PATCH In review John Rigby 2 participants 3 messages Dec 1, 2010 – Dec 18, 2010

Subsystems (3)
lore
Share & tools
lore

John Rigby

author
#0 lore raw

PATCH 1/1 OMAP4: enable smc instruction in new assembler versions

New assemblers need -march=armv7-a+sec on command line or .arch_extension sec inline to enable use of the smc instruction.

This patch uses as-instr to check the latter to conditionally enable the former in AFLAGS for files that use smc.

Checked on both old and new binutils to verify that it does not break old versions.

---
 arch/arm/mach-omap2/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/Makefile +3 -2
index 60e51bc..ee9ef4f 100644
@@ -26,8 +26,9 @@ obj-$(CONFIG_LOCAL_TIMERS)		+= timer-mpu.o
 obj-$(CONFIG_HOTPLUG_CPU)		+= omap-hotplug.o
 obj-$(CONFIG_ARCH_OMAP4)		+= omap44xx-smc.o omap4-common.o
 
-AFLAGS_omap-headsmp.o			:=-Wa,-march=armv7-a
-AFLAGS_omap44xx-smc.o			:=-Wa,-march=armv7-a
+plus_sec := $(call as-instr,.arch_extension sec,+sec)
+AFLAGS_omap-headsmp.o			:=-Wa,-march=armv7-a$(plus_sec)
+AFLAGS_omap44xx-smc.o			:=-Wa,-march=armv7-a$(plus_sec)
 
 # Functions loaded to SRAM
 obj-$(CONFIG_ARCH_OMAP2420)		+= sram242x.o
Signature · 1 line
1.7.3.1.120.g38a18
maintainer
#1 lore raw

PATCH 1/1 OMAP4: enable smc instruction in new assembler versions

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: devel-cleanup

Initial commit ID (Likely to change): fe297dde5ae8f8bf67d3a87759289a99b48ecb2c

PatchWorks
http://patchwork.kernel.org/patch/369681/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=fe297dde5ae8f8bf67d3a87759289a99b48ecb2c

maintainer
#2 lore raw
In reply to John Rigby
Quoted 8 lines · John Rigby

New assemblers need -march=armv7-a+sec on command line or .arch_extension sec inline to enable use of the smc instruction.

This patch uses as-instr to check the latter to conditionally enable the former in AFLAGS for files that use smc.

Checked on both old and new binutils to verify that it does not break old versions.

Thanks applying.

Tony