Skip to contentSkip to conversation

CFLAGS are for C compilers and other Unix traditions

PATCH In review John D. Ramsdell 2 participants 7 messages May 21, 2006 – May 22, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): E1FhcWV-0004n6-Dm@host-192-168-0-1-bcn-london

#1 lore raw

I recognize the vitality of youth, but please allow me to plug some Unix traditions. There is a long tradition on how to write makefiles. Many of these traditions are encoded in the default rules that are part of GNU make. You can see them with the command:

$ make -p

If you execute this command, you will note that the rule for assembling .S files is:

COMPILE.S = $(CC) $(ASFLAGS) $(CPPFLAGS) $(TARGET_MACH) -c

Note that you don't give the assembler CFLAGS. It's not a C compiler.

The default rules use TARGET_MACH in a very well thought out way. Please use TARGET_MACH in a manor consistent with GNU make's default rules.

Another long standing Unix tradition is that applications do not depend on the path environment variable currently in effect. Relying on a path means that a user of an application gets screwy results if they use a non-standard path. More importantly, an application that depends on paths does not allow one to install more than one version of that application.

The Xen application xm fails respect this Unix tradition. Multiple installations of differing versions of xm will get very confused.

John

#2 lore raw
Quoted 7 lines · John D. Ramsdell

If you execute this command, you will note that the rule for assembling .S files is:

COMPILE.S = $(CC) $(ASFLAGS) $(CPPFLAGS) $(TARGET_MACH) -c

Note that you don't give the assembler CFLAGS. It's not a C compiler.

We fixed this for Xen itself some time ago. If there are other places in the tree that do this (maybe minios?), please do provide a patch.

-- Keir

#3 lore raw
Quoted 5 lines · Keir Fraser
Quoted 3 lines · John D. Ramsdell

If you execute this command, you will note that the rule for assembling .S files is:

Quoted 7 lines
Quoted 4 lines

COMPILE.S = $(CC) $(ASFLAGS) $(CPPFLAGS) $(TARGET_MACH) -c

Note that you don't give the assembler CFLAGS. It's not a C compiler.

We fixed this for Xen itself some time ago. If there are other places in the tree that do this (maybe minios?), please do provide a patch.

The Mini-OS makefile was recently patched so as to include the following rules:

%.o: %.c $(HDRS) Makefile

        $(CC) $(CFLAGS) $(CPPFLAGS) -c $< -o $@

%.o: %.S $(HDRS) Makefile

        $(CC) $(ASFLAGS) $(CPPFLAGS) -c $< -o $@

Note the rules fail to include $(TARGET_MACH), which is part of the default rule for COMPILE.S, and $(TARGET_ARCH), which is normally part of COMPILE.c.

When the appropriate GCC backends are installed on an i386 32-bit machine, the $(TARGET_MACH) flags, and the $(TARGET_ARCH) flags can be used to produce a Mini-OS elf file for both the 32 and 64 i386 architectures. You don't have to put your cross compilers in separate locations.

I decided to test the use of Mini-OS as a library. My test application included just one file, app.c, and it resided in a directory outside the Xen sources. I wrote the obvious Makefile, and used the default rule to build app.o from app.c.

This Makefile fails, of course, because $(TARGET_ARCH) is set to x86_32 by Config.mk, and the default rule is:

COMPILE.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c

I hadn't tracked down the source of my problem before I sent my post last night. I somehow thought that COMPILE.c used $(TARGET_MACH), instead of $(TARGET_ARCH), and therefore thought a fix was plausible. I now see that modifying Xen to work with the default rules is a big pain. On the plus side, tracking down this problem forced me to look at Config.mk, and see I can select a cross-compiler by setting CROSS_COMPILER to the bin directory of my cross compiler, rather than setting my path.

John

#4 lore raw
In reply to Keir Fraser

The note I sent contained a misstatement. TARGET_ARCH is being set in the Mini-OS Makefile, not ../../Config.mk. I meant to say that to get all Xen Makefiles to use TARGET_ARCH and TARGET_MACH as they were intended would be a pain. Target information is currently being placed into CFLAGS and LDFLAGS, and one would have to be careful to separate the information correctly. Not worth it.

John

#5 lore raw

PATCH 1/1 Mini-OS Makefile TARGET_ARCH becomes MINIOS_TARGET_ARCH

In reply to Keir Fraser
Quoted 2 lines · Keir Fraser

We fixed this for Xen itself some time ago. If there are other places in the tree that do this (maybe minios?), please do provide a patch.

To facilitate cut-and-paste of portions of the Mini-OS Makefile into other Makefiles, this patch renames TARGET_ARCH to MINIOS_TARGET_ARCH.

John

Only in xxen-unstable/extras/mini-os/console: console.o Only in xxen-unstable/extras/mini-os/console: xencons_ring.o Only in xxen-unstable/extras/mini-os: events.o Only in xxen-unstable/extras/mini-os: hypervisor.o Only in xxen-unstable/extras/mini-os/include: xen Only in xxen-unstable/extras/mini-os: kernel.o Only in xxen-unstable/extras/mini-os/lib: math.o Only in xxen-unstable/extras/mini-os/lib: printf.o Only in xxen-unstable/extras/mini-os/lib: string.o Only in xxen-unstable/extras/mini-os/lib: xmalloc.o Only in xxen-unstable/extras/mini-os: libminios.a

extras/mini-os/Makefile +9 -10
diff -ur axen-unstable/extras/mini-os/Makefile xxen-unstable/extras/mini-os/Makefile
@@ -2,8 +2,8 @@
 
 include $(CURDIR)/../../Config.mk
 
-# Set TARGET_ARCH
-override TARGET_ARCH     := $(XEN_TARGET_ARCH)
+# Set MINIOS_TARGET_OS
+override MINIOS_TARGET_OS     := $(XEN_TARGET_ARCH)
 
 # NB. '-Wcast-qual' is nasty, so I omitted it.
 CFLAGS := -fno-builtin -Wall -Werror -Wredundant-decls -Wno-format
@@ -13,14 +13,14 @@
 ASFLAGS = -D__ASSEMBLY__
 
 LDLIBS =  -L. -lminios
-LDFLAGS := -N -T minios-$(TARGET_ARCH).lds
+LDFLAGS := -N -T minios-$(MINIOS_TARGET_OS).lds
 
-ifeq ($(TARGET_ARCH),x86_32)
+ifeq ($(MINIOS_TARGET_OS),x86_32)
 CFLAGS += -m32 -march=i686
 LDFLAGS += -m elf_i386
 endif
 
-ifeq ($(TARGET_ARCH),x86_64)
+ifeq ($(MINIOS_TARGET_OS),x86_64)
 CFLAGS += -m64 -mno-red-zone -fpic -fno-reorder-blocks
 CFLAGS += -fno-asynchronous-unwind-tables
 LDFLAGS += -m elf_x86_64
@@ -34,7 +34,7 @@
 
 TARGET := mini-os
 
-HEAD := $(TARGET_ARCH).o
+HEAD := $(MINIOS_TARGET_OS).o
 OBJS := $(patsubst %.c,%.o,$(wildcard *.c))
 OBJS += $(patsubst %.c,%.o,$(wildcard lib/*.c))
 OBJS += $(patsubst %.c,%.o,$(wildcard xenbus/*.c))
@@ -54,7 +54,7 @@
 	ar r libminios.a $(HEAD) $(OBJS)
 
 $(TARGET): links libminios.a $(HEAD)
-	$(LD) $(LDFLAGS) $(HEAD) $(LDLIBS) -o [email protected]
+	$(LD) $(LDFLAGS) $(TARGET_ARCH) $(HEAD) $(LDLIBS) -o [email protected]
 	gzip -f -9 -c [email protected] >[email protected]
 
 .PHONY: clean
@@ -65,10 +65,10 @@
 	find . -type l | xargs rm -f
 
 %.o: %.c $(HDRS) Makefile
-	$(CC) $(CFLAGS) $(CPPFLAGS) -c $< -o $@
+	$(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@
 
 %.o: %.S $(HDRS) Makefile
-	$(CC) $(ASFLAGS) $(CPPFLAGS) -c $< -o $@
+	$(CC) $(ASFLAGS) $(CPPFLAGS) $(TARGET_MACH) -c $< -o $@
 
 define all_sources
      ( find . -follow -name SCCS -prune -o -name '*.[chS]' -print )
@@ -78,4 +78,3 @@
 cscope:
 	$(all_sources) > cscope.files
 	cscope -k -b -q
-

Only in xxen-unstable/extras/mini-os: Makefile~ Only in xxen-unstable/extras/mini-os: mini-os.elf Only in xxen-unstable/extras/mini-os: mini-os.gz Only in xxen-unstable/extras/mini-os: mm.o Only in xxen-unstable/extras/mini-os: sched.o Only in xxen-unstable/extras/mini-os: time.o Only in xxen-unstable/extras/mini-os: traps.o Only in xxen-unstable/extras/mini-os: x86_32.o Only in xxen-unstable/extras/mini-os/xenbus: xenbus.o

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#6 lore raw

Re: [PATCH] Mini-OS Makefile TARGET_ARCH becomes MINIOS_TARGET_ARCH

Quoted 5 lines · John D. Ramsdell
Quoted 2 lines

We fixed this for Xen itself some time ago. If there are other places in the tree that do this (maybe minios?), please do provide a patch.

To facilitate cut-and-paste of portions of the Mini-OS Makefile into other Makefiles, this patch renames TARGET_ARCH to MINIOS_TARGET_ARCH.

First, you renamed to MINIOS_TARGET_OS, not _ARCH, which makes no sense. Second, you added references to TARGET_ARCH and TARGET_MACH to rule patterns, which seems unnecessary and might have unwanted side effects.

-- Keir

#7 lore raw

Re: [PATCH] Mini-OS Makefile TARGET_ARCH becomes MINIOS_TARGET_ARCH

Quoted 4 lines · Keir Fraser

First, you renamed to MINIOS_TARGET_OS, not _ARCH, which makes no sense. Second, you added references to TARGET_ARCH and TARGET_MACH to rule patterns, which seems unnecessary and might have unwanted side effects.

Please ignore this patch request. No real need for change.

John