Skip to contentSkip to conversation

1480: ethernet stops working, box okay

PATCH In review Martin Michlmayr 2 participants 4 messages Mar 9, 2006 – Mar 19, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I just thought that my 1480 box had crashed, but as it turns out I could still issue commands on the serial console - however, the network wasn't working anymore. There was nothing in dmesg and bringing the interface down and up again didn't help. I've seen this twice now while compiling lots of stuff in parallel.

Has anyone else seen this?

Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/
#1 lore raw

I have seen something similar on my 1250. I have a patch that should help. I am cleaning it up and will post it shortly.

Tom

Quoted 7 lines · Martin Michlmayr

I just thought that my 1480 box had crashed, but as it turns out I could still issue commands on the serial console - however, the network wasn't working anymore. There was nothing in dmesg and bringing the interface down and up again didn't help. I've seen this twice now while compiling lots of stuff in parallel.

Has anyone else seen this?

Signature · 1 line
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
#2 lore raw

PATCH 1/1 Broadcom Sibyte SB1xxx NAPI ethernet support

This patch adds NAPI support for the Broadcom Sibyte SB1xxx family. The changes are limited to adding a new config key SBMAC_NAPI to the drivers/net/Kconfig and by adding the poll op and interrupt support to drivers/net/sb1250-mac.c.

This patch also has a fix to drivers/net/sb1250-mac.c, the dma descriptor table ptr is allocated, aligned and the aligned ptr is freed. If the ptr was not already aligned (usually is) then the free would not work of what was returned by the kmalloc. A variable was added to store the unaligned pointer so that it could be properly freed.

I have tested this patch on a BCM91250A-SWARM Pass 2 / An.

Mark Mason from Broadcom was very helpful and tested this patch on at least a 1480.

Tom

drivers/net/Kconfig +21 -4
diff -rup a/drivers/net/Kconfig b/drivers/net/Kconfig
@@ -2008,10 +2008,6 @@ config R8169_NAPI
 
 	  If in doubt, say N.
 
-config NET_SB1250_MAC
-	tristate "SB1250 Ethernet support"
-	depends on SIBYTE_SB1xxx_SOC
-
 config R8169_VLAN
 	bool "VLAN support"
 	depends on R8169 && VLAN_8021Q
@@ -2021,6 +2017,27 @@ config R8169_VLAN
 	  
 	  If in doubt, say Y.
 
+config NET_SB1250_MAC
+	tristate "SB1250 Ethernet support"
+	depends on SIBYTE_SB1xxx_SOC
+
+config SBMAC_NAPI
+	bool "Use Rx Polling (NAPI) (EXPERIMENTAL)"
+	depends on NET_SB1250_MAC && EXPERIMENTAL
+	help
+	  NAPI is a new driver API designed to reduce CPU and interrupt load
+	  when the driver is receiving lots of packets from the card. It is
+	  still somewhat experimental and thus not yet enabled by default.
+
+	  If your estimated Rx load is 10kpps or more, or if the card will be
+	  deployed on potentially unfriendly networks (e.g. in a firewall),
+	  then say Y here.
+
+	  See <file:Documentation/networking/NAPI_HOWTO.txt> for more
+	  information.
+
+	  If in doubt, say y.
+
 config SIS190
 	tristate "SiS190/SiS191 gigabit ethernet support"
 	depends on PCI
drivers/net/sb1250-mac.c +98 -30

297 lines not on this page · raw message

#3 lore raw

Re: [PATCH] Broadcom Sibyte SB1xxx NAPI ethernet support

Quoted 4 lines · Tom Rix

This patch adds NAPI support for the Broadcom Sibyte SB1xxx family. The changes are limited to adding a new config key SBMAC_NAPI to the drivers/net/Kconfig and by adding the poll op and interrupt support to drivers/net/sb1250-mac.c.

Thanks, I've not seen a single problem since I applied your patch. I've applied it to the Debian tree.

Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/