AT49BV322A Flash: the erase regions are in the wrong order.

    The device id for this Flash is 0xc8.

Signed-off-by David Wu <[email protected]>

---
  drivers/mtd/cfi_flash.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

drivers/mtd/cfi_flash.c +3 -1

index fdba297..af86f99 100644
@@ -1690,8 +1690,10 @@ static void flash_fixup_atmel(flash_info_t *info,
 struct cfi_qry *qry)
  	/* AT49BV6416(T) list the erase regions in the wrong order.
  	 * However, the device ID is identical with the non-broken
  	 * AT49BV642D they differ in the high byte.
+	 * AT49BV322A is also in the wrong order.
  	 */
-	if (info->device_id == 0xd6 || info->device_id == 0xd2)
+	if (info->device_id == 0xd6 || info->device_id == 0xd2 ||
+	    info->device_id == 0xc8)
  		reverse_geometry = !reverse_geometry;
 

if (reverse_geometry)

Quoted 23 lines · On Thursday 08 April 2010 02:00:23 David Wu wrote:

    The device id for this Flash is 0xc8.

Signed-off-by David Wu <[email protected]>

---
  drivers/mtd/cfi_flash.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

drivers/mtd/cfi_flash.c +3 -1

index fdba297..af86f99 100644
@@ -1690,8 +1690,10 @@ static void flash_fixup_atmel(flash_info_t *info,
 struct cfi_qry *qry)
  	/* AT49BV6416(T) list the erase regions in the wrong order.
  	 * However, the device ID is identical with the non-broken
  	 * AT49BV642D they differ in the high byte.
+	 * AT49BV322A is also in the wrong order.
  	 */
-	if (info->device_id == 0xd6 || info->device_id == 0xd2)
+	if (info->device_id == 0xd6 || info->device_id == 0xd2 ||
+	    info->device_id == 0xc8)
  		reverse_geometry = !reverse_geometry;
 

Quoted 1 line

if (reverse_geometry)

Could you please split this patch from the patch series. I'll push it via the
CFI git repository then. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

I am new here and I am not quite clear about how to split this patch. Any suggestion?

Hi David,

Quoted 2 lines · On Thursday 08 April 2010 17:16:26 David Wu wrote:

I am new here and I am not quite clear about how to split this patch. Any suggestion?

I didn't mean that you should split this patch, but that you should split it
from your *patchset* of 7 parts. Resulting in a patchset with 6 parts ([PATCH
1/6] ...) and one single patch. This way it's easier for me to pick up such a
CFI related patch.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

Quoted 7 lines

I didn't mean that you should split this patch, but that you should split it
from your *patchset* of 7 parts. Resulting in a patchset with 6 parts ([PATCH
1/6] ...) and one single patch. This way it's easier for me to pick up such a
CFI related patch.

OK. Will do it.
A question: Do I have to do this way or just for convenience ? My concerns are
1 more traffic to the list

2 git will complain if applying the patch in the wrong order.

Hi David,

Quoted 8 lines · On Thursday 08 April 2010 17:47:46 David Wu wrote:

Quoted 7 lines

I didn't mean that you should split this patch, but that you should split it
from your *patchset* of 7 parts. Resulting in a patchset with 6 parts ([PATCH
1/6] ...) and one single patch. This way it's easier for me to pick up such a
CFI related patch.

Quoted 4 lines

OK. Will do it.
A question: Do I have to do this way or just for convenience ? My concerns are
1 more traffic to the list

Why would there be more traffic? Previously you did send 7 patches, numbered
1/7 ... 7/7. Now you would send 7 patches 1/6 ... 6/6 plus the CFI patch.

Quoted 1 line

2 git will complain if applying the patch in the wrong order.

The CFI patch is unrelated to the other patches. At least it wont generate any
compilation breakages/problems, if this patch is applied before or after your
other Coldfire patches.
Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

I think those patches if I resubmit are same as before except the subjects differ.

Anyway If no one complains then I will send.