Add libapr-package

PATCH New Rico Bachmann 4 participants 7 messages Apr 17, 2012

lore

Share & tools

lore

Rico Bachmann

author

2012-04-17 10:59 UTC #0 lore raw

PATCH 1/1 Add libapr-package

Signed-off-by Rico Bachmann <[email protected]>

---
 package/Config.in        |    1 +
 package/libapr/Config.in |    7 +++++++
 package/libapr/libapr.mk |   12 ++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libapr/Config.in
 create mode 100644 package/libapr/libapr.mk

package/Config.in +1 -0

index 4c6d4d8..ceb5f6d 100644
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
+source "package/libapr/Config.in"
 source "package/libatomic_ops/Config.in"
 source "package/libcap/Config.in"
 source "package/libcap-ng/Config.in"

package/libapr/Config.in new file +7 -0

new file mode 100644
index 0000000..51dea91
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+
+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
+
+	  http://apr.apache.org/

package/libapr/libapr.mk new file +12 -0

new file mode 100644
index 0000000..57da8ef
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
+
+$(eval $(call AUTOTARGETS))

Signature · 1 line

1.7.2.5

Maxime Ripard

2012-04-17 11:36 UTC #1 lore raw

PATCH 1/1 Add libapr-package

Hi,

Thanks for your patch!

Le 17/04/2012 12:59, Rico Bachmann a ?crit :

Quoted 27 lines

Signed-off-by Rico Bachmann <[email protected]>

---
 package/Config.in        |    1 +
 package/libapr/Config.in |    7 +++++++
 package/libapr/libapr.mk |   12 ++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libapr/Config.in
 create mode 100644 package/libapr/libapr.mk

package/Config.in +1 -0

index 4c6d4d8..ceb5f6d 100644
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
+source "package/libapr/Config.in"
 source "package/libatomic_ops/Config.in"
 source "package/libcap/Config.in"
 source "package/libcap-ng/Config.in"

package/libapr/Config.in new file +0 -0

new file mode 100644
index 0000000..51dea91

package/libapr/Config.in line 5

Quoted 5 lines

package/libapr/Config.in new file +5 -0

@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+
+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations

Could you wrap this line to 80 characters ?

Quoted 7 lines

package/libapr/Config.in new file +1 -0
+	  http://apr.apache.org/
package/libapr/libapr.mk new file +0 -0
new file mode 100644
index 0000000..57da8ef

package/libapr/libapr.mk line 10

Quoted 10 lines

package/libapr/libapr.mk new file +10 -0

@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared

All the ac_cv_* stuff should go into LIBAPR_CONF_ENV variable. You should wrap the line to 80 characters also. --enabled-shared is automatically set by buildroot if it needs to when the package is built, so you don't need to set it here.

Otherwise, it looks good to me.

Thanks,
Maxime

Signature · 4 lines

Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Rico Bachmann

author

2012-04-17 12:18 UTC #2 lore raw

PATCH 1/1 Add libapr-package

Am 17.04.2012, 13:36 Uhr, schrieb Maxime Ripard
<[email protected]>:

Quoted 34 lines

Hi,

Thanks for your patch!

Le 17/04/2012 12:59, Rico Bachmann a ?crit :

Quoted 29 lines

Signed-off-by: Rico Bachmann
<[email protected]>

---
 package/Config.in        |    1 +
 package/libapr/Config.in |    7 +++++++
 package/libapr/libapr.mk |   12 ++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libapr/Config.in
 create mode 100644 package/libapr/libapr.mk

package/Config.in +1 -0

index 4c6d4d8..ceb5f6d 100644
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
+source "package/libapr/Config.in"
 source "package/libatomic_ops/Config.in"
 source "package/libcap/Config.in"
 source "package/libcap-ng/Config.in"

package/libapr/Config.in new file +1 -0

new file mode 100644
index 0000000..51dea91
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR

Quoted 8 lines

Quoted 6 lines
package/libapr/Config.in new file +4 -0
+
+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to  
create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
Could you wrap this line to 80 characters ?

I will wrap this line in my next patch

Quoted 18 lines

package/libapr/Config.in new file +1 -0

+	  http://apr.apache.org/

package/libapr/libapr.mk new file +10 -0

new file mode 100644
index 0000000..57da8ef
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes

Quoted 8 lines

Quoted 3 lines
apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
All the ac_cv_* stuff should go into LIBAPR_CONF_ENV variable. You should wrap the line to 80 characters also. --enabled-shared is automatically set by buildroot if it needs to when the package is built, so you don't need to set it here.

Ok i will add the apr_cv_* stuff to LIBAPR_CONF_ENV instead of LIBAPR_CONF_OPT
and delete the --enable-shared argument

Quoted 6 lines

Otherwise, it looks good to me.
Thanks,
Maxime

Signature · 1 line

Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/

Thomas Petazzoni

2012-04-17 11:39 UTC #3 lore raw

PATCH 1/1 Add libapr-package

In reply to Rico Bachmann

Hello Rico,

Thanks for this contribution!

Le Tue, 17 Apr 2012 12:59:30 +0200,
Rico Bachmann <[email protected]> a ?crit :

Review line 2

Quoted 4 lines

+++ b/package/libapr/Config.in
(quoted diff) +2 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+

Remove this blank line.

package/libapr/Config.in line 5

Quoted 3 lines

package/libapr/Config.in new file +3 -0

+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations

This text should be wrapped at ~80 columns.

package/libapr/libapr.mk line 7

Quoted 12 lines

new file mode 100644
index 0000000..57da8ef

package/libapr/libapr.mk new file +7 -0

@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz

Yegor's suggestion didn't work because by default we download <package-name>-<package-version>.tar.gz. However here you decided to name the Buildroot package "libapr", while the upstream package is "apr". Maybe we should use the "apr" name like upstream?

package/libapr/libapr.mk line 10

Quoted 3 lines

package/libapr/libapr.mk new file +3 -0

+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared

Please wrap this this way:

LIBAPR_CONF_OPT = \
	ac_cv_file__dev_zero=yes \
	ac_cv_func_setgrp_void=yes \
	...

And remove --enable-shared since it is already passed by default, and tuned when BR2_PREFER_STATIC is used.

Regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Peter Korsgaard

2012-04-17 12:01 UTC #4 lore raw

PATCH 1/1 Add libapr-package

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 3 lines

package/libapr/Config.in line 5

Quoted 3 lines

package/libapr/Config.in new file +3 -0

+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations

Thomas> This text should be wrapped at ~80 columns.

And the upstream URL should be added below.

Quoted 4 lines

Quoted 4 lines
new file mode 100644
index 0000000..57da8ef
package/libapr/libapr.mk new file +0 -0

Quoted 8 lines

package/libapr/libapr.mk line 7

Quoted 8 lines

package/libapr/libapr.mk new file +7 -0

@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz

Thomas> Yegor's suggestion didn't work because by default we download Thomas> <package-name>-<package-version>.tar.gz. However here you decided to Thomas> name the Buildroot package "libapr", while the upstream package is Thomas> "apr". Maybe we should use the "apr" name like upstream?

Agreed.

Quoted 1 line

package/libapr/libapr.mk line 8
Quoted 1 line
package/libapr/libapr.mk new file +1 -0
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr

I know the apr website directs you to a local mirror, but perhaps it would make more sense to use archive.apache.org/dist/apr instead of this .ch mirror?

Signature · 1 line

Bye, Peter Korsgaard

Rico Bachmann

author

2012-04-17 12:22 UTC #5 lore raw

PATCH 1/1 Add libapr-package

Am 17.04.2012, 14:01 Uhr, schrieb Peter Korsgaard
<[email protected]>:

Quoted 36 lines

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
"Thomas" == Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/[email protected]> writes:
Hi,
Quoted 3 lines
package/libapr/Config.in
Quoted 3 lines
package/libapr/Config.in new file +3 -0
+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to  
create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
Thomas> This text should be wrapped at ~80 columns.
And the upstream URL should be added below.
Quoted 4 lines
Quoted 4 lines
new file mode 100644
index 0000000..57da8ef
package/libapr/libapr.mk new file +0 -0
Quoted 8 lines
package/libapr/libapr.mk line 7
Quoted 8 lines
package/libapr/libapr.mk new file +7 -0
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
Thomas> Yegor's suggestion didn't work because by default we download Thomas> <package-name>-<package-version>.tar.gz. However here you
decided to
Thomas> name the Buildroot package "libapr", while the upstream package
is
Thomas> "apr". Maybe we should use the "apr" name like upstream?

Quoted 1 line

Agreed.

I'll do that change with my next patch

Quoted 7 lines

Quoted 2 lines
package/libapr/libapr.mk line 8
Quoted 2 lines
package/libapr/libapr.mk new file +1 -0
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
I know the apr website directs you to a local mirror, but perhaps it would make more sense to use archive.apache.org/dist/apr instead of this .ch mirror?

ah i didn't saw that i used a local mirror, i'll change that to.

Signature · 1 line

Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/

Rico Bachmann

author

2012-04-17 12:18 UTC #6 lore raw

PATCH 1/1 Add libapr-package

In reply to Thomas Petazzoni

Am 17.04.2012, 13:39 Uhr, schrieb Thomas Petazzoni <[email protected]>:

Quoted 7 lines

Hello Rico,
Thanks for this contribution!
Le Tue, 17 Apr 2012 12:59:30 +0200,
Rico Bachmann <[email protected]> a ?crit :

Quoted 6 lines

Review line 2
Quoted 4 lines
+++ b/package/libapr/Config.in
(quoted diff) +2 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+
Remove this blank line.

the line will be gone with my next patch :)

Quoted 18 lines

Quoted 6 lines
package/libapr/Config.in new file +3 -0
+	bool "libapr"
+	help
+	  The mission of the Apache Portable Runtime (APR) project is to  
create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
This text should be wrapped at ~80 columns.
Quoted 9 lines
new file mode 100644
index 0000000..57da8ef
package/libapr/libapr.mk new file +4 -0
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#

Quoted 8 lines

package/libapr/libapr.mk line 7
Quoted 3 lines
package/libapr/libapr.mk new file +3 -0
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
Yegor's suggestion didn't work because by default we download <package-name>-<package-version>.tar.gz. However here you decided to name the Buildroot package "libapr", while the upstream package is "apr". Maybe we should use the "apr" name like upstream?

if it is the preferred way I can change the name of the package to arp and delete the LIBAPR_SOURCE line, that's no problem

Quoted 21 lines

Quoted 7 lines
package/libapr/libapr.mk new file +3 -0
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes  
apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
Please wrap this this way:
LIBAPR_CONF_OPT = \
	ac_cv_file__dev_zero=yes \
	ac_cv_func_setgrp_void=yes \
	...
And remove --enable-shared since it is already passed by default, and tuned when BR2_PREFER_STATIC is used.
Regards,
Thomas

Signature · 1 line

Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/