Skip to contentSkip to conversation

ARM: dts: kirkwood: add Linksys EA4500

PATCH New Luka Perkov 5 participants 8 messages Nov 4, 2015 – Nov 24, 2015

Subsystems (2)
Device tree bindings Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Luka Perkov

author
#0 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

Based on dts files from OpenWrt.

Signed-off-by Luka Perkov <[email protected]>
---
 .../devicetree/bindings/arm/marvell,kirkwood.txt   |   1 +
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-ea4500.dts              | 156 +++++++++++++++++++++
 4 files changed, 159 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-ea4500.dts
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
index 5171ad8..7a99d4a 100644
@@ -49,6 +49,7 @@ board. Currently known boards are:
 "lacie,netspace_max_v2"
 "lacie,netspace_mini_v2"
 "lacie,netspace_v2"
+"linksys,ea4500"
 "marvell,db-88f6281-bp"
 "marvell,db-88f6282-bp"
 "marvell,mv88f6281gtw-ge"
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 82d2ac9..264f8ba 100644
@@ -124,6 +124,7 @@ lantiq	Lantiq Semiconductor
 lenovo	Lenovo Group Ltd.
 lg	LG Corporation
 linux	Linux-specific binding
+linksys	Belkin International, Inc.
 lsi	LSI Corp. (LSI Logic)
 lltc	Linear Technology Corporation
 marvell	Marvell Technology Group Ltd.
arch/arm/boot/dts/Makefile +1 -0
index bb8fa02..a16c04b 100644
@@ -168,6 +168,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ds411.dtb \
 	kirkwood-ds411j.dtb \
 	kirkwood-ds411slim.dtb \
+	kirkwood-ea4500.dtb \
 	kirkwood-goflexnet.dtb \
 	kirkwood-guruplug-server-plus.dtb \
 	kirkwood-ib62x0.dtb \
arch/arm/boot/dts/kirkwood-ea4500.dts new file +156 -0

156 lines not on this page · raw message

Signature · 1 line
2.6.2
maintainer
#1 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

arch/arm/boot/dts/kirkwood-ea4500.dts line 20

Quoted 3 lines · On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote:
arch/arm/boot/dts/kirkwood-ea4500.dts new file +3 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", "marvell,kirkwood";

According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple versions of this device, and at least EA4500v3 is completely incompatible with the version in this patch. Should we add "linksys,ea4500v1" as a compatible string to identify this better?

Arnd

author
#2 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

Quoted 9 lines · Arnd Bergmann

arch/arm/boot/dts/kirkwood-ea4500.dts line 20

Quoted 3 lines · On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote:
arch/arm/boot/dts/kirkwood-ea4500.dts new file +3 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", "marvell,kirkwood";

According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple versions of this device, and at least EA4500v3 is completely incompatible with the version in this patch. Should we add "linksys,ea4500v1" as a compatible string to identify this better?

Right. I'll send v2 after getting some more comments.

Luka

#3 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

Hey Luka,

Quoted 11 lines · Luka Perkov
Quoted 9 lines · Arnd Bergmann

arch/arm/boot/dts/kirkwood-ea4500.dts line 20

Quoted 3 lines · On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote:
arch/arm/boot/dts/kirkwood-ea4500.dts new file +3 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", "marvell,kirkwood";

According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple versions of this device, and at least EA4500v3 is completely incompatible with the version in this patch. Should we add "linksys,ea4500v1" as a compatible string to identify this better?

Quoted 1 line

Right. I'll send v2 after getting some more comments.

Did I miss the v2?

thx,

Jason.

author
#4 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

Hi Jason,

Quoted 12 lines · Jason Cooper
Quoted 11 lines · Luka Perkov
Quoted 9 lines · Arnd Bergmann

arch/arm/boot/dts/kirkwood-ea4500.dts line 20

Quoted 3 lines · On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote:
arch/arm/boot/dts/kirkwood-ea4500.dts new file +3 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", "marvell,kirkwood";

According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple versions of this device, and at least EA4500v3 is completely incompatible with the version in this patch. Should we add "linksys,ea4500v1" as a compatible string to identify this better?

Quoted 3 lines
Quoted 1 line

Right. I'll send v2 after getting some more comments.

Did I miss the v2?

Nope, I'll send it out next week.

Regards,
Luka

#5 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

In reply to Arnd Bergmann
Quoted 13 lines · Arnd Bergmann
Quoted 4 lines · On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote:
arch/arm/boot/dts/kirkwood-ea4500.dts new file +3 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282",

"marvell,kirkwood";

According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple versions
of this device, and at least EA4500v3 is completely incompatible with the version
in this patch. Should we add "linksys,ea4500v1" as a compatible string to identify
this better?

Not sure, as "v1" is never marked on the box/boards, and for this reason as far as I remember, we've never marked "v1" on any upstream code (unlike vX).

Imre

#6 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

In reply to Luka Perkov

Documentation/devicetree/bindings/vendor-prefixes.txt lantiq Lantiq Semiconductor · line 130

Quoted 12 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 82d2ac9..264f8ba 100644
@@ -124,6 +124,7 @@ lantiq	Lantiq Semiconductor
 lenovo	Lenovo Group Ltd.
 lg	LG Corporation
 linux	Linux-specific binding
+linksys	Belkin International, Inc.
 lsi	LSI Corp. (LSI Logic)
 lltc	Linear Technology Corporation
 marvell	Marvell Technology Group Ltd.

Hi Luka

This part should probably be a patch of its own, sent to the DT maintainers.

Documentation/devicetree/bindings/vendor-prefixes.txt

Quoted 11 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +11 -0
+/ {
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x8000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";

Please use stdout-path = &uart0; You can also put the baud rate etc on the end.

Quoted 4 lines

+&nand {

Documentation/devicetree/bindings/vendor-prefixes.txt +3 -0
+	status = "okay";
+	pinctrl-0 = <&pmx_nand>;
+	pinctrl-names = "default";

Documentation/devicetree/bindings/vendor-prefixes.txt

Quoted 10 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +10 -0
+
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x80000>;
+	};
+
+	partition at 80000 {
+		label = "u-boot environment";
+		reg = <0x80000 0x20000>;
+	};

Is there a hole here?

Quoted 17 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +16 -0
+
+	partition at 200000 {
+		label = "kernel";
+		reg = <0x200000 0x200000>;
+	};
+
+	partition at 400000 {
+		label = "root";
+		reg = <0x400000 0x1c00000>;
+	};
+};
 
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		speed = <1000>;
+		duplex = <1>;

Documentation/devicetree/bindings/vendor-prefixes.txt

Quoted 10 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +10 -0
+	};
+};
+
+&eth1 {
+	status = "okay";
+	ethernet1-port at 0 {
+		speed = <1000>;
+		duplex = <1>;
+	};
+};

Why fix the speed? Are they connected to a switch?

Andrew

#7 lore raw

PATCH 1/4 ARM: dts: kirkwood: add Linksys EA4500

In reply to Luka Perkov

On Wed, 04 Nov 2015 23:25:05 +0100, Luka Perkov <[email protected]> wrote:

<snip>

Documentation/devicetree/bindings/arm/marvell,kirkwood.txt board. Currently known boards are: · line 55

Quoted 10 lines
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
@@ -49,6 +49,7 @@ board. Currently known boards are:
 "lacie,netspace_max_v2"
 "lacie,netspace_mini_v2"
 "lacie,netspace_v2"
+"linksys,ea4500"
 "marvell,db-88f6281-bp"
 "marvell,db-88f6282-bp"
 "marvell,mv88f6281gtw-ge"

The same device was sold as the ea4200v2 as well. Please use the engineering name "viper" instead, as discussed at
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/319590.html

Documentation/devicetree/bindings/vendor-prefixes.txt lantiq Lantiq Semiconductor · line 130

Quoted 10 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -124,6 +124,7 @@ lantiq	Lantiq Semiconductor
 lenovo	Lenovo Group Ltd.
 lg	LG Corporation
 linux	Linux-specific binding
+linksys	Belkin International, Inc.
 lsi	LSI Corp. (LSI Logic)
 lltc	Linear Technology Corporation
 marvell	Marvell Technology Group Ltd.

Although Linksys is a subsidiary of Belkin, I think linksys should stay Linksys here ;)

arch/arm/boot/dts/Makefile dtb-$(CONFIG_MACH_KIRKWOOD) += \ · line 174

Quoted 12 lines
arch/arm/boot/dts/Makefile +1 -0
index bb8fa02..a16c04b 100644
@@ -168,6 +168,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ds411.dtb \
 	kirkwood-ds411j.dtb \
 	kirkwood-ds411slim.dtb \
+	kirkwood-ea4500.dtb \
 	kirkwood-goflexnet.dtb \
 	kirkwood-guruplug-server-plus.dtb \
 	kirkwood-ib62x0.dtb \

"kirkwood-viper.dtb"

Quoted 3 lines
arch/arm/boot/dts/kirkwood-ea4500.dts new file +0 -0
@@ -0,0 +1,156 @@

<snip>

Quoted 3 lines
arch/arm/boot/dts/kirkwood-ea4500.dts new file +2 -0
+	model = "Linksys EA4500";
+	compatible = "linksys,ea4500", "marvell,kirkwood-88f6282",

"marvell,kirkwood";

model = "Linksys EA4200v2 / EA4500"
compatible = "linksys,viper", "marvell,kirkwood-88f6282", "marvell,kirkwood";

<snip>

Quoted 15 lines

+&nand {

arch/arm/boot/dts/kirkwood-ea4500.dts new file +14 -0
+	status = "okay";
+	pinctrl-0 = <&pmx_nand>;
+	pinctrl-names = "default";
+
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x80000>;
+	};
+
+	partition at 80000 {
+		label = "u-boot environment";
+		reg = <0x80000 0x20000>;
+	};
+

arch/arm/boot/dts/kirkwood-ea4500.dts line 136

Quoted 10 lines
arch/arm/boot/dts/kirkwood-ea4500.dts new file +10 -0
+	partition at 200000 {
+		label = "kernel";
+		reg = <0x200000 0x200000>;
+	};
+
+	partition at 400000 {
+		label = "root";
+		reg = <0x400000 0x1c00000>;
+	};
+};

Please use the factory partitions instead.

Imre