Skip to contentSkip to conversation

status of DRM_MGA on x86_64

DISCUSSION Andi Kleen 4 participants 6 messages Oct 30, 2004 – Nov 1, 2004 5 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#4 lore raw
Quoted 5 lines · Thomas Zehetbauer
Quoted 4 lines · Ian Romanick

The problem, which exists with most (all?) DRM drivers, is that data types are used in the kernel/user interface that have different sizes on LP32 and LP64. If your kernel is 64-bit, you will have problems with 32-bit applications.

That was not the reason I disabled it. I reenabled it now in my tree.

Quoted 7 lines

Then either all or no DRM drivers should be enabled on x86_64, the DRM_TDFX, DRM_R128, DRM_RADEON and DRM_SIS are not currently disabled. I vote for enabling all drivers that work with 64-bit applications.

I wonder if this should be the first and only place where different kernel/userland bitness causes problems. How has this been solved elsewhere?

It was solved long ago for the Radeon driver by Egbert Eich. But for some unknown reason the DRI people never merged his patches.

-Andi

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

sorry missed the list....

---------- Forwarded message ----------
From: Dave Airlie <[email protected]>
Date: Sat, 30 Oct 2004 21:15:45 +1000
Subject: Re: status of DRM_MGA on x86_64
To: Andi Kleen <[email protected]>

Quoted 3 lines

It was solved long ago for the Radeon driver by Egbert Eich. But for some unknown reason the DRI people never merged his patches.

Because no-one agreed that his solution was clean enough for use, no-one contributed well described patches of the separate pieces to drm or dri,

At the moment any solution to the 32/64-bit DRI will either break pure 64-bit systems or break 32/64-bit mixed systems, nobody has stepped forward and said that either of these are acceptable, and no drm developer has the hardware to work on it,

This 64-bit vs 32/64-bit stuff has been on my drm todo list for ages but I've neither received clean patches or someone who has the test environment to convince me that breaking one or other of the currently working systems is acceptable... so we are currently in a state of breaking backwards compat for 64-bit vs breaking backways compat for 32/64-bit.... I've no idea which one is acceptable, and I'm not going to spend time developing a patch for one to have it refused because it breaks compat with the other....

Someone needs to make the big decision, (IMHO only Linus or Andrew can really make it as it's their kernels that will have the issues...)

Dave.

#7 lore raw

Could you or someone else please explain the problem?

From rom what I have read it seems that userland acesses some bitness dependent kernel structures. Fixing this would mean to use architecture independent structures in both kernel- and userland and break existing applications.

As a user I would be satisfied if DRI is available for 64-bit applications on x86_64 and 32-bit applications do not cause the kernel to crash.

Tom

PS: I have Fedora running on a dual Opteron system with a Matrox Millenium G550, tell me if you want to test something.

Signature · 6 lines
  T h o m a s   Z e h e t b a u e r   ( TZ251 )
  PGP encrypted mail preferred - KeyID 96FFCB89
      finger [email protected] for key

Attempting to apply the OSI layers model to a real network is just like
attempting to represent seven dimensions in four dimensional reality.
#8 lore raw
In reply to Andi Kleen
Quoted 14 lines · Andi Kleen
Quoted 5 lines · Thomas Zehetbauer
Quoted 4 lines · Ian Romanick

The problem, which exists with most (all?) DRM drivers, is that data types are used in the kernel/user interface that have different sizes on LP32 and LP64. If your kernel is 64-bit, you will have problems with 32-bit applications.

That was not the reason I disabled it. I reenabled it now in my tree.

Quoted 3 lines

Then either all or no DRM drivers should be enabled on x86_64, the DRM_TDFX, DRM_R128, DRM_RADEON and DRM_SIS are not currently disabled. I vote for enabling all drivers that work with 64-bit applications.

Quoted 7 lines
Quoted 3 lines

I wonder if this should be the first and only place where different kernel/userland bitness causes problems. How has this been solved elsewhere?

It was solved long ago for the Radeon driver by Egbert Eich. But for some unknown reason the DRI people never merged his patches.

I solved it for RADEON, MGA and R128.
It would be interesting to solve this for the i915 driver, too, and possibly some others.

That it hasn't been merged into DRI yet is a shame. Appearantly nobody has ever realized why this stuff is useful. Unfortunately I don't have the time for lobbying it.
It's a very boring undertaking to have to port this from one DRI version to the next.

Egbert.

#9 lore raw
Quoted 10 lines

I solved it for RADEON, MGA and R128.
It would be interesting to solve this for the i915 driver, too, and possibly some others.

That it hasn't been merged into DRI yet is a shame. Appearantly nobody has ever realized why this stuff is useful. Unfortunately I don't have the time for lobbying it.
It's a very boring undertaking to have to port this from one DRI version to the next.

Ian, can you look at this I think you are the best person (maybe Keithw) to tell whether this stuff breaks compat in any direction,. Egbert you may not want to lobby for it but all I personally want to know is what it might potentially break in terms of backwards compatiblity.... from SuSEs point of view as long as a distro is consistent then you are okay, for us the whole keeping DRIs built against older kernels working with newer kernels is the only real issue...

Hopefully Ian can look at the patch and decide on it....

Dave.

Dave.

#10 lore raw
Quoted 9 lines · Dave Airlie

Ian, can you look at this I think you are the best person (maybe Keithw) to tell whether this stuff breaks compat in any direction,. Egbert you may not want to lobby for it but all I personally want to know is what it might potentially break in terms of backwards compatiblity.... from SuSEs point of view as long as a distro is consistent then you are okay, for us the whole keeping DRIs built against older kernels working with newer kernels is the only real issue...

Right. I know. I've looked into this.
I thought I had fixed the last remaining backward compatibility between kernel and DRI (libraries and Xserver) by adding compatibility ioctls.
I still plan to revisit this issue and see if I can modify the code such that I don't need those compatibility ioctls.

Quoted 3 lines

Hopefully Ian can look at the patch and decide on it....

OK. An earlier version is in the freedesktop CVS (#943). If you want I make a port to the DRI head. Unfortunately I probably won't be able to get at it for the next 2 - 3 weeks.

Egbert.