Skip to contentSkip to conversation

FEATURE REQUEST: Specific Processor Optimizations on x86 Architecture

DISCUSSION Andi Kleen 2 participants 2 messages Nov 18, 2003 6 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): Pine.LNX.4.53.0310271603580.21953@montezuma.fsmlabs.com.suse.lists.linux.kernel

Andi Kleen

author
#6 lore raw
Quoted 9 lines · Zwane Mwaikambo
Quoted 4 lines · Andi Kleen

The wmb() change is not needed, unless you have an oostore CPU (x86 has ordered writes by default). It probably does not hurt neither though (I do it the same way on x86-64), but also doesn't change anything.

The original intent was to fix an SMP P5 system, it oopses otherwise under load.

That doesn't make any sense. P5 doesn't support SFENCE.

-Andi

#7 lore raw
Quoted 9 lines · Andi Kleen
Quoted 7 lines · Zwane Mwaikambo
Quoted 4 lines · Andi Kleen

The wmb() change is not needed, unless you have an oostore CPU (x86 has ordered writes by default). It probably does not hurt neither though (I do it the same way on x86-64), but also doesn't change anything.

Quoted 4 lines
Quoted 2 lines

The original intent was to fix an SMP P5 system, it oopses otherwise under load.

That doesn't make any sense. P5 doesn't support SFENCE.

I think i misparsed what you were referring to, i thought it was the patch with the barrier in smp_call_function().

My bad.