Skip to contentSkip to conversation

SPAM: Re: XFS corruption during power-blackout

DISCUSSION Andi Kleen 2 participants 2 messages Jun 29, 2005 – Jun 30, 2005 5 messages not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 556815.441dd7d1ebc32b4a80e049e0ddca5d18e872c6e8a722b2aefa7525e9504533049d801014.ANY@taniwha.stupidest.org.suse.lists.linux.kernel

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 254889.27725ab660aa106eb6acc07307d71ef1fbd5b6fd366aebef9e2f611750fbcb467e46e8a4.IBX@taniwha.stupidest.org.suse.lists.linux.kernel

Andi Kleen

author
#5 lore raw
Quoted 3 lines · Chris Wedgwood

If caching is enabled I still lose data. Linux does have a concept of write barriers but these are presently not implemented for XFS right now.

I implemented them some time ago for log writes in XFS. Not for fsync though, although fsync usually does a log write afterwards so it should work in practice too. fdatasync might not.

Don't know if the code hasn't bit rotted away and it also was a bit dumb. It was definitely there at some point.

But then a lot of ATA disks and SCSI don't support barriers. Or at least the IDE barrier tests fails on several of my machines.

-Andi

#6 lore raw
Quoted 2 lines · Andi Kleen

Don't know if the code hasn't bit rotted away and it also was a bit dumb. It was definitely there at some point.

It did rot away sadly but someone (speak up!) was working on a newer version of this I just don't know how much time they've had to work on this recently.

Quoted 2 lines

But then a lot of ATA disks and SCSI don't support barriers. Or at least the IDE barrier tests fails on several of my machines.

IDE has no barriers. I thought the kernel was aware of this and flushed when in those cases? Does that not work?