[PATCH} Network interface for IPMI
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · Corey Minyard
I have decided
that the network interface for IPMI is a good thing, as the IPMI device ioctls have pointers and require ugly hacks. None should be needed for the network interface.
That's a joke, right?
Review
Quoted 3 lines
(quoted diff) +3
-0+struct ipmi_sock_msg { + int recv_type; + long msgid;
^^^^^^^^^^^
Of course long would need to be always emulated. Your patch shows exactly why packet based protocols for this are a bad idea. The problem is that people will get it wrong, and then it's nearly impossible to fix for a socket based protocol because read/write cannot be easily hooked
(with ipsec we have exactly this problem already)
ioctls at least can be fixed up. Please keep using them.
Review
Quoted 2 lines
(quoted diff) +2
-0+ int data_len; + unsigned char data[0];
And I don't even want to know what's in there.
Andrew, please don't apply this broken patch.
-Andi
Ok, I agree. You are right, at least the ioctls can be fixed up.
-Corey
Quoted 47 lines · Andi Kleen
Quoted 6 lines · Corey Minyard
I have decided
that the network interface for IPMI is a good thing, as the IPMI device ioctls have pointers and require ugly hacks. None should be needed for the network interface.That's a joke, right?
Review
Quoted 5 lines
(quoted diff) +3
-0+struct ipmi_sock_msg { + int recv_type; + long msgid;^^^^^^^^^^^Of course long would need to be always emulated. Your patch shows exactly why packet based protocols for this are a bad idea. The problem is that people will get it wrong, and then it's nearly impossible to fix for a socket based protocol because read/write cannot be easily hooked
(with ipsec we have exactly this problem already)ioctls at least can be fixed up. Please keep using them.
Review
Quoted 4 lines
(quoted diff) +2
-0+ int data_len; + unsigned char data[0];And I don't even want to know what's in there.
Andrew, please don't apply this broken patch.
-Andi