Skip to contentSkip to conversation

backport AMD K7 MCE changes.

DISCUSSION Andi Kleen 1 participant 1 message Oct 3, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw

Review

Quoted 5 lines · Dave Jones
(quoted diff) +3 -1
 			 */
-			if(c->x86 == 6 || c->x86 == 15)
+			
+			if(c->x86 == 6 || c->x86 == 15) {
+				startbank = 1;

Can you please add comments to such magic changes ?

I still think we should not do anything without an official errata.

The K7 actually has two MCE enable registers: a mask that is only supposed to be programmed by the BIOS and works around bugs and the standardized IA32 register controlled by the OS. I suspect your case only happens with some buggy BIOS that doesn't program the shadow mask correctly. This would imply that it would make more sense to test it and program it correctly based on a known good value.

-Andi