Skip to contentSkip to conversation

sched.c: why -fno-omit-frame-pointer?

DISCUSSION Adrian Bunk 4 participants 4 messages Aug 19, 2007 – Aug 23, 2007

lore
Share & tools
lore
#0 lore raw

kernel/sched.c gets compiled with -fno-omit-frame-pointer, and this was already done in kernel 1.0 (sic).

Later, it has been modified to be this way only on some architectures.

It might not be an earthshaking amount, but removing it saves some bytes, and there's no visible breakage when running the modified kernel on i386.

$ ls -la kernel/sched.o*
-rw-rw-r-- 1 bunk bunk 25600 2007-08-19 16:10 kernel/sched.o
-rw-rw-r-- 1 bunk bunk 26084 2007-08-19 16:03 kernel/sched.o.old
$ size kernel/sched.o*
   text    data     bss     dec     hex filename
  11835     184    2000   14019    36c3 kernel/sched.o
  12321     184    2000   14505    38a9 kernel/sched.o.old
$ 

Is the -fno-omit-frame-pointer still required for some reason, or is this a relict that could be removed?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 9 lines · Adrian Bunk

kernel/sched.c gets compiled with -fno-omit-frame-pointer, and this was already done in kernel 1.0 (sic).

Later, it has been modified to be this way only on some architectures.

It might not be an earthshaking amount, but removing it saves some bytes, and there's no visible breakage when running the modified kernel on i386.

vague memory: this was needed for wchan to work properly

#2 lore raw
In reply to Adrian Bunk
Quoted 3 lines · Adrian Bunk

Is the -fno-omit-frame-pointer still required for some reason, or is this a relict that could be removed?

It's needed so that the WCHAN /proc display can backtrace one level up out of schedule()

-Andi

#3 lore raw
Quoted 7 lines · Andi Kleen
Quoted 3 lines · Adrian Bunk

Is the -fno-omit-frame-pointer still required for some reason, or is this a relict that could be removed?

It's needed so that the WCHAN /proc display can backtrace one level up out of schedule()

it's not just one level - we'll back out until we are in scheduler functions (up to 16 levels). So it will back out of io_schedule() and other functions as well.

Ingo