Skip to contentSkip to conversation

arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address

DISCUSSION Mathieu Desnoyers 2 participants 2 messages Aug 30, 2006

lore
Share & tools
lore
#0 lore raw

Hi,

I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to verify that an address can potentially belong to kernel code. However, this version takes a spinlock and should not be called from oops. I think __kernel_text_address would be more appropriate there.

Mathieu Desnoyers

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
#1 lore raw
Quoted 6 lines · Mathieu Desnoyers

Hi,

I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to verify that an address can potentially belong to kernel code. However, this version takes a spinlock and should not be called from oops. I think __kernel_text_address would be more appropriate there.

Ok I changed it. Thanks

-Andi