Skip to contentSkip to conversation

oops with dual xeon 2.8ghz 4gb ram +smp, software raid, lvm, and xfs

DISCUSSION Andi Kleen 1 participant 1 message Nov 27, 2004 7 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#7 lore raw
Quoted 11 lines · Andrew Morton
Quoted 3 lines

I can't say I love the idea of adding a bio list structure to the tasklist, it feels pretty hacky. generic_make_request() doesn't really use that much stack, if you just kill the BDEVNAME_SIZE struct.

Looks like a sensible thing to do, although it would be tidier to move the whole thing into a separate function, no?

drivers/block/ll_rw_blk.c static inline void block_wait_queue_runn · line 2587

Quoted 4 lines
drivers/block/ll_rw_blk.c renamed from drivers/block/ll_rw_blk.c~generic_make_request-stack-savings +1 -0
@@ -2584,6 +2584,20 @@ static inline void block_wait_queue_runn
 	}
 }
 
+static void handle_bad_sector(struct bio *bio)

You need to mark it noinline, otherwise a unit-at-a-time gcc (3.4+) will happily inline it anyways.

-Andi