Skip to contentSkip to conversation

package/libnatpmp: fix header install

PATCH Applied Bernd Kuhls 2 participants 3 messages Jul 3, 2023 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libnatpmp: fix header install

Upstream renamed declspec.h to natpmp_declspec.h
https://github.com/miniupnp/libnatpmp/commit/1d113363980a98a5868ff2c2b05d7c94e3a18a70

---
 package/libnatpmp/libnatpmp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libnatpmp/libnatpmp.mk +1 -1
index 3a625ea0fe..99d46d814a 100644
@@ -18,7 +18,7 @@ endef
 define LIBNATPMP_INSTALL_STAGING_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
 		PREFIX=$(STAGING_DIR) \
-		HEADERS='declspec.h natpmp.h' \
+		HEADERS='natpmp_declspec.h natpmp.h' \
 		$(TARGET_CONFIGURE_OPTS) install
 endef
 
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Bernd, All,

On 2023-07-03 22:20 +0200, Bernd Kuhls spake thusly:

Quoted 4 lines

Upstream renamed declspec.h to natpmp_declspec.h
https://github.com/miniupnp/libnatpmp/commit/1d113363980a98a5868ff2c2b05d7c94e3a18a70

Applied to master, thanks. But see a question, below...

Quoted 9 lines
---
 package/libnatpmp/libnatpmp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libnatpmp/libnatpmp.mk +0 -0
index 3a625ea0fe..99d46d814a 100644

package/libnatpmp/libnatpmp.mk endef · line 21

Quoted 5 lines
package/libnatpmp/libnatpmp.mk +1 -1
@@ -18,7 +18,7 @@ endef
 define LIBNATPMP_INSTALL_STAGING_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
 		PREFIX=$(STAGING_DIR) \
-		HEADERS='declspec.h natpmp.h' \
+		HEADERS='natpmp_declspec.h natpmp.h' \

So it means 0e258b6190a5 (package/libnatpmp: bump version to 20230423) was not build-tested before being submitted? At least transmission unonditionally uses it, so a runtime test of transmission would catch it.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/libnatpmp/libnatpmp.mk +0 -0
 		$(TARGET_CONFIGURE_OPTS) install
 endef
 
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

A message that is not in the archive (sent off-list or not yet received): 20230703203026.GL2510__34801.2332267658$1688416254$gmane$org@scaer

#3 lore raw

Am Mon, 3 Jul 2023 22:30:26 +0200 schrieb Yann E. MORIN:

Quoted 4 lines

So it means 0e258b6190a5 (package/libnatpmp: bump version to 20230423) was not build-tested before being submitted? At least transmission unonditionally uses it, so a runtime test of transmission would catch it.

Hi Yann,

I build-tested libnatpmp, which showed no errors because the tarball, contrary to https://github.com/miniupnp/libnatpmp, contains declspec.h which is unused by libnatpmp now so I did not catch the change of the header file.

At this stage I did not build-test its dependee package transmission, only later when build-testing all my stuff I noticed the problem and sent the patch right away.

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot