Skip to contentSkip to conversation

nfs-utils/idmapd: use of private define breaks with libevent-2.1.x

DISCUSSION Holger Hoffstätte 2 participants 2 messages Jan 17, 2015 – Jan 23, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello,

The Gentoo community has found a problem with the current release of nfs-utils, where idmapd uses a not strictly private, yet strongly discouraged #define.

Bug description with proposed patch:
https://bugs.gentoo.org/show_bug.cgi?id=446374

The code in question:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=utils/idmapd/idmapd.c;hb=HEAD#l719

According to:
https://github.com/libevent/libevent/blob/master/include/event2/event_struct.h

which says:
"No field declared in this file should be used directly in user code."

using EVLIST_INIT directly is bound to break. This seems to be a leftover from legacy code.

A simple fix is attached to the bugzilla above and just calls the proper public API, which is functionally equivalent to the bit check.

Would be nice to see this in 1.3.2. :)

Thanks!

Holger

#1 lore raw
Quoted 9 lines · Holger Hoffstätte

Hello,

The Gentoo community has found a problem with the current release of nfs-utils, where idmapd uses a not strictly private, yet strongly discouraged #define.

Bug description with proposed patch:
https://bugs.gentoo.org/show_bug.cgi?id=446374

Committed...

steved.

Quoted 27 lines

The code in question:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=utils/idmapd/idmapd.c;hb=HEAD#l719

According to:
https://github.com/libevent/libevent/blob/master/include/event2/event_struct.h

which says:
"No field declared in this file should be used directly in user code."

using EVLIST_INIT directly is bound to break. This seems to be a leftover from legacy code.

A simple fix is attached to the bugzilla above and just calls the proper public API, which is functionally equivalent to the bit check.

Would be nice to see this in 1.3.2. :)

Thanks!

Holger

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html