Skip to contentSkip to conversation

pre-commit hook tests: don't leave "actual" nonexisting on failure

PATCH New Ævar Arnfjörð Bjarmason 1 participant 1 message Jun 14, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pre-commit hook tests: don't leave "actual" nonexisting on failure

Start by creating an "actual" file in a core.hooksPath test that has the hook echoing to the "actual" file.

We later test_cmp that file to see what hooks were run. If we fail to run our hook(s) we'll have an empty list of hooks for the test_cmp instead of a nonexisting file. For the logic of this test that makes more sense.

See 867ad08a261 (hooks: allow customizing where the hook directory is, 2016-05-04) for the commit that added these tests.

---

A trivial test improvement split off from v2 of
https://lore.kernel.org/git/[email protected]/

 t/t1350-config-hooks-path.sh | 1 +
 1 file changed, 1 insertion(+)
t/t1350-config-hooks-path.sh +1 -0
index f1f9aee9f5d..fa9647a7c0b 100755
@@ -5,6 +5,7 @@ test_description='Test the core.hooksPath configuration variable'
 . ./test-lib.sh
 
 test_expect_success 'set up a pre-commit hook in core.hooksPath' '
+	>actual &&
 	mkdir -p .git/custom-hooks .git/hooks &&
 	write_script .git/custom-hooks/pre-commit <<-\EOF &&
 	echo CUSTOM >>actual
Signature · 1 line
2.32.0.rc3.434.gd8aed1f08a7