Use full revision ID for git packages
PATCH 1/1 Use full revision ID for git packages
As discussed recently, we should use full git commit IDs instead of abbreviated ones.
Signed-off-by Thomas De Schampheleire <[email protected]>
--- docs/manual/adding-packages-tips.txt | 5 ++--- package/a10disp/a10disp.mk | 2 +- package/cppzmq/cppzmq.mk | 2 +- package/czmq/czmq.mk | 2 +- package/filemq/filemq.mk | 2 +- package/jsmin/jsmin.mk | 2 +- package/knock/knock.mk | 2 +- package/libnfc/libnfc.mk | 2 +- package/linenoise/linenoise.mk | 2 +- package/lua-ev/lua-ev.mk | 2 +- package/lua-msgpack-native/lua-msgpack-native.mk | 2 +- package/luaexpatutils/luaexpatutils.mk | 2 +- package/mtdev2tuio/mtdev2tuio.mk | 2 +- package/ne10/ne10.mk | 2 +- package/omap-u-boot-utils/omap-u-boot-utils.mk | 2 +- package/on2-8170-modules/on2-8170-modules.mk | 2 +- package/qextserialport/qextserialport.mk | 2 +- package/qtuio/qtuio.mk | 2 +- package/rpi-firmware/rpi-firmware.mk | 2 +- package/rpi-userland/rpi-userland.mk | 2 +- package/socketcand/socketcand.mk | 2 +- package/sunxi-cedarx/sunxi-cedarx.mk | 2 +- package/sunxi-mali-prop/sunxi-mali-prop.mk | 2 +- package/sunxi-mali/sunxi-mali.mk | 2 +- package/ti-utils/ti-utils.mk | 2 +- package/tvheadend/tvheadend.mk | 2 +- package/zmqpp/zmqpp.mk | 2 +- package/zyre/zyre.mk | 2 +- 28 files changed, 29 insertions(+), 30 deletions(-)
PATCH 1/1 manual: github commits should be specified in full
Signed-off-by Thomas De Schampheleire <[email protected]>
--- docs/manual/adding-packages-tips.txt | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
docs/manual/adding-packages-tips.txt +2 -3
@@ -44,7 +44,7 @@ However, it is possible to download tarb on github. ------------------------ -FOO_VERSION = v1.0 # tag or (abbreviated) commit ID +FOO_VERSION = v1.0 # tag or (full) commit ID FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION) ------------------------
@@ -53,5 +53,4 @@ FOO_SITE = http://github.com/<user>/<pac - The tarball name generated by github matches the default one from Buildroot (e.g.: +foo-1234567.tar.gz+), so it is not necessary to specify it in the +.mk+ file. -- When using a commit ID as version, usually the first 7 characters of - the SHA1 are enough. +- When using a commit ID as version, you should use the full 40 hex characters.
PATCH 1/1 manual: github commits should be specified in full
Hi Thomas,
2013/11/2 Thomas De Schampheleire <[email protected]>
Quoted 11 lines
Signed-off-by Thomas De Schampheleire <[email protected]>--- docs/manual/adding-packages-tips.txt | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
docs/manual/adding-packages-tips.txt However, it is possible to download tarb · line 48
Quoted 6 lines
docs/manual/adding-packages-tips.txt +1
-1@@ -44,7 +44,7 @@ However, it is possible to download tarb on github. ------------------------ -FOO_VERSION = v1.0 # tag or (abbreviated) commit ID +FOO_VERSION = v1.0 # tag or (full) commit ID
I think the brackets are not necessary around "full".
FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
docs/manual/adding-packages-tips.txt FOO_SITE = http://github.com/<user>/<pac · line 55
Quoted 6 lines
docs/manual/adding-packages-tips.txt +0
-0------------------------@@ -53,5 +53,4 @@ FOO_SITE = http://github.com/<user>/<pac - The tarball name generated by github matches the default one from Buildroot (e.g.: +foo-1234567.tar.gz+),
The example should use a full commit ID
Quoted 6 lines
docs/manual/adding-packages-tips.txt +1
-2so it is not necessary to specify it in the +.mk+ file. -- When using a commit ID as version, usually the first 7 characters of - the SHA1 are enough. +- When using a commit ID as version, you should use the full 40 hexcharacters.
Otherwise, it looks good to me.
Regards,
Signature · 4 lines
Samuel -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/152c555f/attachment.html>
PATCH 1/1 git packages: use full revision hash
In reply to Thomas De SchampheleireThere is no benefit in using the shortened git revision hash. On the
contrary: the shorter the hash, the higher the risk of having collisions with another commit.
Signed-off-by Thomas De Schampheleire <[email protected]>
--- package/a10disp/a10disp.mk | 2 +- package/cppzmq/cppzmq.mk | 2 +- package/czmq/czmq.mk | 2 +- package/filemq/filemq.mk | 2 +- package/jsmin/jsmin.mk | 2 +- package/knock/knock.mk | 2 +- package/libnfc/libnfc.mk | 2 +- package/linenoise/linenoise.mk | 2 +- package/lua-ev/lua-ev.mk | 2 +- package/lua-msgpack-native/lua-msgpack-native.mk | 2 +- package/luaexpatutils/luaexpatutils.mk | 2 +- package/mtdev2tuio/mtdev2tuio.mk | 2 +- package/ne10/ne10.mk | 2 +- package/omap-u-boot-utils/omap-u-boot-utils.mk | 2 +- package/on2-8170-modules/on2-8170-modules.mk | 2 +- package/qextserialport/qextserialport.mk | 2 +- package/qtuio/qtuio.mk | 2 +- package/rpi-firmware/rpi-firmware.mk | 2 +- package/rpi-userland/rpi-userland.mk | 2 +- package/socketcand/socketcand.mk | 2 +- package/sunxi-cedarx/sunxi-cedarx.mk | 2 +- package/sunxi-mali-prop/sunxi-mali-prop.mk | 2 +- package/sunxi-mali/sunxi-mali.mk | 2 +- package/ti-utils/ti-utils.mk | 2 +- package/tvheadend/tvheadend.mk | 2 +- package/zmqpp/zmqpp.mk | 2 +- package/zyre/zyre.mk | 2 +- 27 files changed, 27 insertions(+), 27 deletions(-)
package/a10disp/a10disp.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -A10DISP_VERSION = a899cc6dcf +A10DISP_VERSION = a899cc6dcf909360aac00482ede5369f3656f226 A10DISP_SITE = http://github.com/hglm/a10disp/tarball/$(A10DISP_VERSION) A10DISP_LICENSE = MIT
package/cppzmq/cppzmq.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -CPPZMQ_VERSION = b232978 +CPPZMQ_VERSION = b23297800389149ac37f19b7215fa4734d344998 CPPZMQ_SITE = git://github.com/zeromq/cppzmq.git CPPZMQ_INSTALL_STAGING = YES CPPZMQ_DEPENDENCIES = zeromq
package/czmq/czmq.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -CZMQ_VERSION = cb9839cf90 +CZMQ_VERSION = cb9839cf90e4ac69acb7c6ff2b4e2d42d704cf6e CZMQ_SITE = git://github.com/zeromq/czmq.git # Autoreconf required as we use the git tree
package/filemq/filemq.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -FILEMQ_VERSION = 8fac5140dd +FILEMQ_VERSION = 8fac5140ddbca3c4742016795fbbf1d6579902f3 FILEMQ_SITE = git://github.com/zeromq/filemq.git FILEMQ_AUTORECONF = YES
package/jsmin/jsmin.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -JSMIN_VERSION = a9b4755 +JSMIN_VERSION = a9b47554d5684a55301a2eb7ca8480b7ee7630d4 JSMIN_SITE = http://github.com/douglascrockford/JSMin/tarball/$(JSMIN_VERSION) define JSMIN_BUILD_CMDS
package/knock/knock.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -KNOCK_VERSION = 7666f2e86e +KNOCK_VERSION = 7666f2e86e18d482eaad5fe1fea46d87d80b0555 KNOCK_SITE = https://github.com/jvinet/knock/tarball/master KNOCK_LICENSE = GPLv2+ KNOCK_LICENSE_FILES = COPYING
package/libnfc/libnfc.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LIBNFC_VERSION = fda8d60ce062 +LIBNFC_VERSION = fda8d60ce062409bb32c76a229f02f7502948ce8 LIBNFC_SITE = http://libnfc.googlecode.com/git/ LIBNFC_SITE_METHOD = git LIBNFC_LICENSE = LGPLv3+
package/linenoise/linenoise.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LINENOISE_VERSION = 27a3b4d5 +LINENOISE_VERSION = 27a3b4d5205a5fb3e2101128edd6653bd0c92189 LINENOISE_SITE = http://github.com/antirez/linenoise/tarball/$(LINENOISE_VERSION) LINENOISE_LICENSE = BSD-2c LINENOISE_INSTALL_STAGING = YES
package/lua-ev/lua-ev.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LUA_EV_VERSION = 458165b +LUA_EV_VERSION = 458165bdfe0c6eadc788813925f11a0e6a823845 LUA_EV_SITE = http://github.com/brimworks/lua-ev/tarball/$(LUA_EV_VERSION) LUA_EV_DEPENDENCIES = lua libev LUA_EV_LICENSE = MIT
package/lua-msgpack-native/lua-msgpack-native.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LUA_MSGPACK_NATIVE_VERSION = 41cce91 +LUA_MSGPACK_NATIVE_VERSION = 41cce91ab6b54e4426c6d626a0ac41a02ec2096d LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/$(LUA_MSGPACK_NATIVE_VERSION) LUA_MSGPACK_NATIVE_DEPENDENCIES = lua LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0
package/luaexpatutils/luaexpatutils.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LUAEXPATUTILS_VERSION = 88c228365b +LUAEXPATUTILS_VERSION = 88c228365b084224c911d34aff06002634b38b50 LUAEXPATUTILS_SITE = http://github.com/stevedonovan/LuaExpatUtils/tarball/$(LUAEXPATUTILS_VERSION) LUAEXPATUTILS_LICENSE = Public Domain LUAEXPATUTILS_DEPENDENCIES = luaexpat
package/mtdev2tuio/mtdev2tuio.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -MTDEV2TUIO_VERSION = e1e7378 +MTDEV2TUIO_VERSION = e1e7378d86abe751158e743586133022f32fa4d1 MTDEV2TUIO_SITE = http://github.com/olivopaolo/mtdev2tuio/tarball/$(MTDEV2TUIO_VERSION) MTDEV2TUIO_DEPENDENCIES = mtdev liblo MTDEV2TUIO_LICENSE = GPLv3+
package/ne10/ne10.mk +1 -1
@@ -6,7 +6,7 @@ # We use a Git commit ID because the last tagged version is more than # one year old. -NE10_VERSION = 88c18f0 +NE10_VERSION = 88c18f02199947b2c8b57796f5a3ca53160aff96 NE10_SITE = http://github.com/projectNe10/Ne10/tarball/$(NE10_VERSION) NE10_LICENSE = BSD-3c or Apache 2.0 NE10_LICENSE_FILES = doc/LICENSE
package/omap-u-boot-utils/omap-u-boot-utils.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -OMAP_U_BOOT_UTILS_VERSION = 8aff852 +OMAP_U_BOOT_UTILS_VERSION = 8aff852322c6f52bd09568bef7725ab509d81725 OMAP_U_BOOT_UTILS_SITE = http://github.com/nmenon/omap-u-boot-utils/tarball/$(OMAP_U_BOOT_UTILS_VERSION) OMAP_U_BOOT_UTILS_LICENSE = GPLv2, GPLv2+ OMAP_U_BOOT_UTILS_LICENSE_FILES = COPYING
package/on2-8170-modules/on2-8170-modules.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -ON2_8170_MODULES_VERSION = 73b0806 +ON2_8170_MODULES_VERSION = 73b08061d30789178e692bc332b73d1d9922bf39 ON2_8170_MODULES_SITE = http://github.com/alexandrebelloni/on2-8170-modules/tarball/$(ON2_8170_MODULES_VERSION) ON2_8170_MODULES_DEPENDENCIES = linux
package/qextserialport/qextserialport.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -QEXTSERIALPORT_VERSION = 6c47244de4ce6db +QEXTSERIALPORT_VERSION = 6c47244de4ce6db43c2f05caee957666c951dae1 QEXTSERIALPORT_SITE = https://qextserialport.googlecode.com/git/ QEXTSERIALPORT_SITE_METHOD = git
package/qtuio/qtuio.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -QTUIO_VERSION = abe4973ff6 +QTUIO_VERSION = abe4973ff60654aad9df7037c4ca15c45f811d24 QTUIO_SITE = git://github.com/x29a/qTUIO.git QTUIO_INSTALL_STAGING = YES QTUIO_DEPENDENCIES = qt
package/rpi-firmware/rpi-firmware.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -RPI_FIRMWARE_VERSION = 58036da +RPI_FIRMWARE_VERSION = 58036da500d936a98156d703fa220dc7db175762 RPI_FIRMWARE_SITE = http://github.com/raspberrypi/firmware/tarball/$(RPI_FIRMWARE_VERSION) RPI_FIRMWARE_LICENSE = BSD-3c RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
package/rpi-userland/rpi-userland.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -RPI_USERLAND_VERSION = 77d32cd +RPI_USERLAND_VERSION = 77d32cd6b7d1c586877b0e05f941e647e35084bc RPI_USERLAND_SITE = http://github.com/raspberrypi/userland/tarball/$(RPI_USERLAND_VERSION) RPI_USERLAND_LICENSE = BSD-3c RPI_USERLAND_LICENSE_FILES = LICENCE
package/socketcand/socketcand.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -SOCKETCAND_VERSION = dc3437ab +SOCKETCAND_VERSION = dc3437abf17359fa8cb16567415b47e7ef8568d0 SOCKETCAND_SITE = http://github.com/dschanoeh/socketcand/tarball/$(SOCKETCAND_VERSION) SOCKETCAND_AUTORECONF = YES
package/sunxi-cedarx/sunxi-cedarx.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -SUNXI_CEDARX_VERSION = 74923e55fc +SUNXI_CEDARX_VERSION = 74923e55fc3ef512d4cd2462da58ae5331611f37 SUNXI_CEDARX_SITE = http://github.com/linux-sunxi/cedarx-libs/tarball/$(SUNXI_CEDARX_VERSION) SUNXI_CEDARX_INSTALL_STAGING = YES
package/sunxi-mali-prop/sunxi-mali-prop.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -SUNXI_MALI_PROP_VERSION = e4ced47 +SUNXI_MALI_PROP_VERSION = e4ced471d576708ac9aa093e41a0f91cf429862b SUNXI_MALI_PROP_SITE = http://github.com/linux-sunxi/sunxi-mali-proprietary/tarball/$(SUNXI_MALI_PROP_VERSION) $(eval $(generic-package))
package/sunxi-mali/sunxi-mali.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -SUNXI_MALI_VERSION = c2491fe952 +SUNXI_MALI_VERSION = c2491fe952354ba44538064e534ed7c731cedb1e SUNXI_MALI_SITE = http://github.com/linux-sunxi/sunxi-mali/tarball/$(SUNXI_MALI_VERSION) SUNXI_MALI_INSTALL_STAGING = YES
package/ti-utils/ti-utils.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -TI_UTILS_VERSION = 06dbdb2 +TI_UTILS_VERSION = 06dbdb2727354b5f3ad7c723897f40051fddee49 TI_UTILS_SITE = http://github.com/gxk/ti-utils/tarball/$(TI_UTILS_VERSION) TI_UTILS_DEPENDENCIES = libnl
package/tvheadend/tvheadend.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -TVHEADEND_VERSION = 2b64995 +TVHEADEND_VERSION = 2b649954346aa2e9c81834d500a25c528f31f829 TVHEADEND_SITE = git://github.com/tvheadend/tvheadend.git TVHEADEND_LICENSE = GPLv3+ TVHEADEND_LICENSE_FILES = LICENSE
package/zmqpp/zmqpp.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -ZMQPP_VERSION = 31220ca +ZMQPP_VERSION = 31220ca4a0fb43a0848d78f5e4f23fce39945777 ZMQPP_SITE = git://github.com/benjamg/zmqpp.git ZMQPP_INSTALL_STAGING = YES ZMQPP_DEPENDENCIES = zeromq
package/zyre/zyre.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -ZYRE_VERSION = 44a57a449a +ZYRE_VERSION = 44a57a449a34bb6310b5ce4b17f1ce42f9b17beb ZYRE_SITE = git://github.com/zeromq/zyre.git ZYRE_LICENSE = LGPLv3+ ZYRE_LICENSE_FILES = COPYING COPYING.LESSER
PATCH 1/1 git packages: use full revision hash
2013/11/2 Thomas De Schampheleire <[email protected]>
Quoted 6 lines
There is no benefit in using the shortened git revision hash. On the
contrary: the shorter the hash, the higher the risk of having collisions with another commit.Signed-off-by Thomas De Schampheleire <[email protected]>
Acked-by Samuel Martin <[email protected]>
Regards,
Signature · 4 lines
Samuel -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/74784e53/attachment.html>
PATCH 1/1 git packages: use full revision hash
In reply to Thomas De SchampheleireThomas DS, All,
On 2013-11-02 13:11 +0100, Thomas De Schampheleire spake thusly:
Quoted 5 lines
There is no benefit in using the shortened git revision hash. On the
contrary: the shorter the hash, the higher the risk of having collisions with another commit.Signed-off-by Thomas De Schampheleire <[email protected]>
For those pacakges I care about:
Quoted 3 lines
package/rpi-firmware/rpi-firmware.mk | 2 +- package/rpi-userland/rpi-userland.mk | 2 +- package/tvheadend/tvheadend.mk | 2 +-
Acked-by "Yann E. MORIN" <[email protected]>
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'