Skip to contentSkip to conversation

Add some missing comments for toolchain option dependencies

PATCH New Thomas De Schampheleire 2 participants 8 messages Dec 18, 2013 – Dec 19, 2013

lore
Share & tools
lore

Thomas De Schampheleire

author
#0 lore raw

PATCH 1/1 Add some missing comments for toolchain option dependencies

Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/gawk/Config.in          |  4 ++--
 package/mongrel2/Config.in      |  7 +++++++
 package/p11-kit/Config.in       |  4 ++--
 package/qt5/qt5quick1/Config.in |  7 ++++---
 package/tzdata/Config.in        |  3 +++
 package/udev/Config.in          |  4 ++++
 6 files changed, 22 insertions(+), 7 deletions(-)
author
#1 lore raw

PATCH 1/1 mongrel2: add missing comment for toolchain option dependencies

Signed-off-by Thomas De Schampheleire <[email protected]>

---
Note: I treated the uClibc || eglibc || arm as a base (positive) dependency, not mentioned in the comment.

 package/mongrel2/Config.in |  7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
package/mongrel2/Config.in +7 -0
@@ -1,3 +1,10 @@
+comment "mongrel2 needs a toolchain w/ C++, IPv6, threads, largefile, wchar"
+	depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
+		BR2_TOOLCHAIN_USES_GLIBC || \
+		BR2_arm
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_INET_IPV6 || \
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE || !BR2_USE_WCHAR
+
 config BR2_PACKAGE_MONGREL2
 	bool "mongrel2"
 	select BR2_PACKAGE_SQLITE
author
#2 lore raw

PATCH 1/1 tzdata: add missing comment for toolchain option dependencies

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/tzdata/Config.in |  3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
package/tzdata/Config.in +3 -0
@@ -1,3 +1,6 @@
+comment "tzdata needs an (e)glibc toolchain"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
 config BR2_PACKAGE_TZDATA
 	bool "tzdata"
 	depends on BR2_TOOLCHAIN_USES_GLIBC
author
#3 lore raw

PATCH 1/1 qt5quick1: add missing comment for toolchain option dependencies

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/qt5/qt5quick1/Config.in |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
package/qt5/qt5quick1/Config.in +4 -3
@@ -20,6 +20,7 @@ config BR2_PACKAGE_QT5QUICK1
 
 	  http://qt-project.org
 
-comment "qt5quick1 requires an OpenGL-capable backend"
-	depends on (!BR2_PACKAGE_HAS_OPENGL_EGL || !BR2_PACKAGE_HAS_OPENGL_ES) && \
-		BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+comment "qt5quick1 needs a toolchain w/ dynamic library and an OpenGL-capable backend"
+	depends on BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+	depends on !BR2_PACKAGE_HAS_OPENGL_EGL || !BR2_PACKAGE_HAS_OPENGL_ES || \
+		BR2_PREFER_STATIC_LIB
author
#4 lore raw

PATCH 1/1 p11-kit: add missing comment for dynamic library support

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/p11-kit/Config.in |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/p11-kit/Config.in +2 -2
@@ -11,6 +11,6 @@ config BR2_PACKAGE_P11_KIT
 
 	  http://p11-glue.freedesktop.org/p11-kit.html
 
-comment "p11-kit needs a toolchain w/ threads"
+comment "p11-kit needs a toolchain w/ threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
author
#5 lore raw

PATCH 1/1 udev: add missing comment for toolchain option dependencies

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/udev/Config.in |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
package/udev/Config.in +4 -0
@@ -43,3 +43,7 @@ endif
 comment "udev requires /dev mgmnt set to udev under System configuration"
 	depends on !BR2_avr32
 	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+
+comment "udev needs a toolchain w/ largefile, wchar, dynamic library"
+	depends on !BR2_avr32
+	depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB
author
#6 lore raw

PATCH 1/1 gawk: add missing comment for toolchain option dependencies

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/gawk/Config.in |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/gawk/Config.in +2 -2
@@ -10,6 +10,6 @@ config BR2_PACKAGE_GAWK
 
 	  http://www.gnu.org/software/gawk/
 
-comment "gawk needs a toolchain w/ wchar"
+comment "gawk needs a toolchain w/ wchar, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR
+	depends on !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB