Skip to contentSkip to conversation

Unify comments on udev /dev management dependency

PATCH New Thomas De Schampheleire 2 participants 4 messages Dec 19, 2013

lore
Share & tools
lore

Thomas De Schampheleire

author
#0 lore raw

PATCH 1/1 Unify comments on udev /dev management dependency

Signed-off-by Thomas De Schampheleire <[email protected]>

--

 docs/manual/adding-packages-directory.txt |  17 +++++++++++++++++
 package/libmbim/Config.in                 |   2 +-
 package/modem-manager/Config.in           |   2 +-
 package/network-manager/Config.in         |   5 +++--
 package/systemd/Config.in                 |   2 +-
 package/udev/Config.in                    |   9 +++------
 6 files changed, 26 insertions(+), 11 deletions(-)
author
#1 lore raw

PATCH 1/1 Config.in files: unify comment dependency on udev /dev management

Signed-off-by Thomas De Schampheleire <[email protected]>

---
Note: this patch builds on top of the previous series (also touching package/udev/Config.in)

 package/libmbim/Config.in         |  2 +-
 package/modem-manager/Config.in   |  2 +-
 package/network-manager/Config.in |  5 +++--
 package/systemd/Config.in         |  2 +-
 package/udev/Config.in            |  9 +++------
 5 files changed, 9 insertions(+), 11 deletions(-)
package/libmbim/Config.in +1 -1
@@ -12,6 +12,6 @@ config BR2_PACKAGE_LIBMBIM
 
 	  http://www.freedesktop.org/wiki/Software/libmbim/
 
-comment "libmbim needs udev and a toolchain w/ wchar, threads"
+comment "libmbim needs udev /dev management and a toolchain w/ wchar, threads"
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
package/modem-manager/Config.in +1 -1
@@ -31,6 +31,6 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
 	  This option enables support for QMI protocol
 endif
 
-comment "modemmanager needs udev and a toolchain w/ largefile, wchar, threads, IPv6"
+comment "modemmanager needs udev /dev management and a toolchain w/ largefile, wchar, threads, IPv6"
 	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
package/network-manager/Config.in +3 -2
@@ -28,8 +28,9 @@ config BR2_PACKAGE_NETWORK_MANAGER
 
 	  http://projects.gnome.org/NetworkManager/
 
-comment "NetworkManager needs a toolchain w/ IPv6, largefile, wchar, threads"
+comment "NetworkManager needs udev /dev management and a toolchain w/ IPv6, largefile, wchar, threads"
 	depends on !BR2_avr32
 	depends on BR2_USE_MMU
 	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
package/systemd/Config.in +1 -1
@@ -20,5 +20,5 @@ config BR2_PACKAGE_SYSTEMD
 
 comment "systemd needs udev /dev management and a toolchain w/ IPv6, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || !BR2_INET_IPV6 || \\
+	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || !BR2_INET_IPV6 || \
 		!BR2_TOOLCHAIN_HAS_THREADS
package/udev/Config.in +3 -6
@@ -40,10 +40,7 @@ comment "enabling all extras needs a too
 
 endif
 
-comment "udev requires /dev mgmnt set to udev under System configuration"
+comment "udev needs udev /dev management and a toolchain w/ largefile, wchar, dynamic library"
 	depends on !BR2_avr32
-	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
-
-comment "udev needs a toolchain w/ largefile, wchar, dynamic library"
-	depends on !BR2_avr32
-	depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB
+	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || \
+		!BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB
author
#2 lore raw

PATCH 1/1 manual: explain format of comment about udev /dev management dependency

In reply to Thomas De Schampheleire
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 docs/manual/adding-packages-directory.txt |  17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
docs/manual/adding-packages-directory.txt +17 -0
@@ -270,6 +270,23 @@ kernel, use this format:
 foo needs a toolchain w/ featA, featB, featC and a Linux kernel to be built
 --------------------------
 
+Dependencies on udev /dev management
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+If a package needs udev /dev management, it should depend on symbol
++BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV+, and the following comment
+should be added:
+
+--------------------------
+foo needs udev /dev management
+--------------------------
+
+If there is a dependency on both toolchain options and udev /dev
+management, use this format:
+
+--------------------------
+foo needs udev /dev management and a toolchain w/ featA, featB, featC
+--------------------------
+
 The +.mk+ file
 ~~~~~~~~~~~~~~
 [[adding-packages-mk]]