phy: exynos5-usbdrd: Remove error print for devm_add_action_or_reset()
Subsystems (2)
PATCH v2 1/1 phy: exynos5-usbdrd: Remove error print for devm_add_action_or_reset()
When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/phy/samsung/phy-exynos5-usbdrd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/phy/samsung/phy-exynos5-usbdrd.c +1 -2
@@ -1859,8 +1859,7 @@ static int exynos5_usbdrd_setup_notifiers(struct exynos5_usbdrd_phy *phy_drd) exynos5_usbdrd_orien_switch_unregister, phy_drd);if (ret) -return dev_err_probe (phy_drd->dev, ret, -"Failed to register TypeC orientation devm action\n" ); +return ret; }return 0 ;
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
Signature · 1 line
2.39.5
Quoted 5 lines · On Tue, Aug 05, 2025 at 11:33 +0200 Waqar Hameed <[email protected]> wrote:
When
devm_add_action_or_reset()fails, it is due to a failed memory allocation and will thus return-ENOMEM.dev_err_probe()doesn't do anything when error is-ENOMEM. Therefore, remove the useless call todev_err_probe()whendevm_add_action_or_reset()fails, and just return the value instead.
Friendly ping incoming!
Quoted 1 line · On Fri, Oct 10, 2025 at 15:39 +0200 Waqar Hameed <[email protected]> wrote:
On Tue, Aug 05, 2025 at 11:33 +0200 Waqar Hameed <[email protected]> wrote:
[...]
Quoted 1 line
Friendly ping incoming!
Friendly ping 2 incoming!
This will be the last ping for the original patch [1]. I'll interpret the silence as a NACK (though it would preferable to get an explicit one...). All other patches in the previous patch series has been merged [2].
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
Tudor Ambarus
Reviewed-byQuoted 4 lines · Waqar Hameed
Quoted 1 line · On Fri, Oct 10, 2025 at 15:39 +0200 Waqar Hameed <[email protected]> wrote:
On Tue, Aug 05, 2025 at 11:33 +0200 Waqar Hameed <[email protected]> wrote:
Quoted 8 lines
[...]
Quoted 1 line
Friendly ping incoming!
Friendly ping 2 incoming!
This will be the last ping for the original patch [1]. I'll interpret the silence as a NACK (though it would preferable to get an explicit
The patch is fine, I think it just slipped through the cracks:
Quoted 6 lines
one...). All other patches in the previous patch series has been merged [2].
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/