Skip to contentSkip to conversation

input: zforce_ts: Remove error print for devm_add_action_or_reset()

PATCH In review Waqar Hameed 1 participant 3 messages Aug 5, 2025 – May 20

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 input: zforce_ts: Remove error print for devm_add_action_or_reset()

When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.

---
Changes in v2:

* Split the patch to one seperate patch for each sub-system.

Link to v1: https://lore.kernel.org/all/[email protected]/

 drivers/input/touchscreen/zforce_ts.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/touchscreen/zforce_ts.c +1 -2
index df42fdf36ae3..4d000b5b3ae6 100644
@@ -739,8 +739,7 @@ static int zforce_probe(struct i2c_client *client)
 
 	error = devm_add_action_or_reset(&client->dev, zforce_reset, ts);
 	if (error)
-		return dev_err_probe(&client->dev, error,
-				     "failed to register reset action\n");
+		return error;
 
 	snprintf(ts->phys, sizeof(ts->phys),
 		 "%s/input0", dev_name(&client->dev));

base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2

Signature · 1 line
2.39.5
#1 lore raw
Quoted 5 lines · On Tue, Aug 05, 2025 at 11:33 +0200 Waqar Hameed <[email protected]> wrote:

When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.

Friendly ping incoming!

#2 lore raw
Quoted 1 line · On Fri, Oct 10, 2025 at 15:36 +0200 Waqar Hameed <[email protected]> wrote:

On Tue, Aug 05, 2025 at 11:33 +0200 Waqar Hameed <[email protected]> wrote:

[...]

Quoted 1 line

Friendly ping incoming!

Friendly ping 2 incoming!

This will be the last ping for the original patch [1]. I'll interpret the silence as a NACK (though it would preferable to get an explicit one...). All other patches in the previous patch series has been merged [2].

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/