scsi: ufs: core: Remove error print for devm_add_action_or_reset()
Subsystems (2)
PATCH v2 1/1 scsi: ufs: core: Remove error print for devm_add_action_or_reset()
When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/ufs/core/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/ufs/core/ufshcd.c +1 -2
@@ -10476,8 +10476,7 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle) err =devm_add_action_or_reset (dev, ufshcd_devres_release, host);if (err) -return dev_err_probe (dev, err, -"failed to add ufshcd dealloc action\n" ); +return err; host->nr_maps =HCTX_TYPE_POLL +1 ; hba =shost_priv (host);
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
Signature · 1 line
2.39.5
Martin K. Petersen
AppliedWaqar,
Quoted 5 lines
When
devm_add_action_or_reset()fails, it is due to a failed memory allocation and will thus return-ENOMEM.dev_err_probe()doesn't do anything when error is-ENOMEM. Therefore, remove the useless call todev_err_probe()whendevm_add_action_or_reset()fails, and just return the value instead.
Applied to 6.17/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen
Martin K. Petersen
AppliedQuoted 8 lines · Waqar Hameed
When
devm_add_action_or_reset()fails, it is due to a failed memory allocation and will thus return-ENOMEM.dev_err_probe()doesn't do anything when error is-ENOMEM. Therefore, remove the useless call todev_err_probe()whendevm_add_action_or_reset()fails, and just return the value instead.[...]
Applied to 6.17/scsi-fixes, thanks!
[1/1] scsi: ufs: core: Remove error print for devm_add_action_or_reset()
https://git.kernel.org/mkp/scsi/c/72fc388d8bc0
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering