Skip to contentSkip to conversation

pack-revindex.h: fix typos of time complexity

PATCH In review Kyle Zhao via GitGitGadget 4 participants 6 messages Sep 15, 2021 – Sep 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pack-revindex.h: fix typos of time complexity

From: kylezhao <[email protected]>

---
pack-revindex.h: fix typos of time complexity

It looks like the time complexity descriptions were written wrong.

Regards, Kyle

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1039%2Fkeyu98%2Fkz%2Ffix-pack-revindex-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1039/keyu98/kz/fix-pack-revindex-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1039

 pack-revindex.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
pack-revindex.h +2 -2
index 479b8f2f9c9..74f4eae668d 100644
@@ -109,7 +109,7 @@ off_t pack_pos_to_offset(struct packed_git *p, uint32_t pos);
  * If the reverse index has not yet been loaded, or the position is out of
  * bounds, this function aborts.
  *
- * This function runs in time O(log N) with the number of objects in the MIDX.
+ * This function runs in constant time.
  */
 uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
 
@@ -120,7 +120,7 @@ uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
  * If the reverse index has not yet been loaded, or the position is out of
  * bounds, this function aborts.
  *
- * This function runs in constant time.
+ * This function runs in time O(log N) with the number of objects in the MIDX.
  */
 int midx_to_pack_pos(struct multi_pack_index *midx, uint32_t at, uint32_t *pos);
 

base-commit: 8b7c11b8668b4e774f81a9f0b4c30144b818f1d1

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 40 lines · Kyle Zhao via GitGitGadget

From: kylezhao <[email protected]>

---
pack-revindex.h: fix typos of time complexity

It looks like the time complexity descriptions were written wrong.

Regards, Kyle

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1039%2Fkeyu98%2Fkz%2Ffix-pack-revindex-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1039/keyu98/kz/fix-pack-revindex-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1039

  pack-revindex.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
pack-revindex.h +2 -2
index 479b8f2f9c9..74f4eae668d 100644
@@ -109,7 +109,7 @@ off_t pack_pos_to_offset(struct packed_git *p, uint32_t pos);
   * If the reverse index has not yet been loaded, or the position is out of
   * bounds, this function aborts.
   *
- * This function runs in time O(log N) with the number of objects in the MIDX.
+ * This function runs in constant time.
   */
  uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
 
@@ -120,7 +120,7 @@ uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
   * If the reverse index has not yet been loaded, or the position is out of
   * bounds, this function aborts.
   *
- * This function runs in constant time.
+ * This function runs in time O(log N) with the number of objects in the MIDX.
   */
  int midx_to_pack_pos(struct multi_pack_index *midx, uint32_t at, uint32_t *pos);
 
Quoted 2 lines

base-commit: 8b7c11b8668b4e774f81a9f0b4c30144b818f1d1

The commit message should be "time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped, correct it". Of course, this is not typofix.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#2 lore raw

PATCH v2 1/1 pack-revindex.h: correct the time complexity descriptions

In reply to Kyle Zhao via GitGitGadget

From: kylezhao <[email protected]>

Time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped, correct it.

---
pack-revindex.h: correct the time complexity descriptions

It looks like the time complexity descriptions were written wrong.

Regards, Kyle

Changes since v1:

* changed the commit message

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1039%2Fkeyu98%2Fkz%2Ffix-pack-revindex-typo-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1039/keyu98/kz/fix-pack-revindex-typo-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1039

Range-diff vs v1:

1: 8915a8f55ba ! 1: a2e9df25ac9 pack-revindex.h: fix typos of time complexity
@@ Metadata
Author: kylezhao <[email protected]>

## Commit message ##
- pack-revindex.h: fix typos of time complexity
+ pack-revindex.h: correct the time complexity descriptions
+
+ Time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped,
+ correct it.

 pack-revindex.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
pack-revindex.h +2 -2
index 479b8f2f9c9..74f4eae668d 100644
@@ -109,7 +109,7 @@ off_t pack_pos_to_offset(struct packed_git *p, uint32_t pos);
  * If the reverse index has not yet been loaded, or the position is out of
  * bounds, this function aborts.
  *
- * This function runs in time O(log N) with the number of objects in the MIDX.
+ * This function runs in constant time.
  */
 uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
 
@@ -120,7 +120,7 @@ uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
  * If the reverse index has not yet been loaded, or the position is out of
  * bounds, this function aborts.
  *
- * This function runs in constant time.
+ * This function runs in time O(log N) with the number of objects in the MIDX.
  */
 int midx_to_pack_pos(struct multi_pack_index *midx, uint32_t at, uint32_t *pos);
 

base-commit: 8b7c11b8668b4e774f81a9f0b4c30144b818f1d1

Signature · 1 line
gitgitgadget
Reviewed-by on v2 1/1
#3 lore raw

Re: [PATCH v2] pack-revindex.h: correct the time complexity descriptions

Quoted 7 lines · Kyle Zhao via GitGitGadget

From: kylezhao <[email protected]>

Time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped, correct it.

---

<snip>...

Quoted 26 lines
  pack-revindex.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
pack-revindex.h +2 -2
index 479b8f2f9c9..74f4eae668d 100644
@@ -109,7 +109,7 @@ off_t pack_pos_to_offset(struct packed_git *p, uint32_t pos);
   * If the reverse index has not yet been loaded, or the position is out of
   * bounds, this function aborts.
   *
- * This function runs in time O(log N) with the number of objects in the MIDX.
+ * This function runs in constant time.
   */
  uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
 
@@ -120,7 +120,7 @@ uint32_t pack_pos_to_midx(struct multi_pack_index *m, uint32_t pos);
   * If the reverse index has not yet been loaded, or the position is out of
   * bounds, this function aborts.
   *
- * This function runs in constant time.
+ * This function runs in time O(log N) with the number of objects in the MIDX.
   */
  int midx_to_pack_pos(struct multi_pack_index *midx, uint32_t at, uint32_t *pos);
 
Quoted 2 lines

base-commit: 8b7c11b8668b4e774f81a9f0b4c30144b818f1d1

OK.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
Reviewed-by on v2 1/1
#4 lore raw

Re: [PATCH v2] pack-revindex.h: correct the time complexity descriptions

In reply to Kyle Zhao via GitGitGadget
Quoted 4 lines · Kyle Zhao via GitGitGadget

From: kylezhao <[email protected]>

Time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped, correct it.

Great eyes! Thanks for noticing and fixing. I took a look through the other three functions which convert between pack offset, pack position, and index position, and those had the correct runtime noted.

But these two were swapped, and are now correct after your patch. Thanks again.

Thanks,
Taylor

#5 lore raw

Re: [PATCH v2] pack-revindex.h: correct the time complexity descriptions

Quoted 7 lines · Taylor Blau

But these two were swapped, and are now correct after your patch. Thanks again.

Thanks,
Taylor

Yup, both are from f894081d (pack-revindex: read multi-pack reverse indexes, 2021-03-30) and a "reviewed-by:" from the person who wrote it certainly is appreciated :-).

Thanks, both.