bugreport: add missing closing bracket in usage line
PATCH 1/1 bugreport: add missing closing bracket in usage line
From: Fangyi Zhou <[email protected]>
---
bugreport: add missing closing bracket in usage line
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1329%2Ffangyi-zhou%2Fbugreport-usage-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1329/fangyi-zhou/bugreport-usage-fix-v1
Pull-Request: https://github.com/git/git/pull/1329
builtin/bugreport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/bugreport.c +1 -1
@@ -60,7 +60,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit) }static const char *const bugreport_usage[] = { -N_ ("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]" ), +N_ ("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]]" ),NULL };
base-commit: d3fa443f97e3a8d75b51341e2d5bac380b7422df
Signature · 1 line
gitgitgadget
Quoted 20 lines · Fangyi Zhou via GitGitGadget
From: Fangyi Zhou <[email protected]>
Signed-off-by Fangyi Zhou <[email protected]>---
bugreport: add missing closing bracket in usage lineSigned-off-by Fangyi Zhou [email protected]Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1329%2Ffangyi-zhou%2Fbugreport-usage-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1329/fangyi-zhou/bugreport-usage-fix-v1
Pull-Request: https://github.com/git/git/pull/1329builtin/bugreport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)builtin/bugreport.c +0
-0
builtin/bugreport.c static void get_populated_hooks(struct strbuf *hook_info, int nongit) · line 65
Quoted 7 lines
builtin/bugreport.c +1
-1@@ -60,7 +60,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit) }static const char *const bugreport_usage[] = { -N_ ("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]" ), +N_ ("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]]" ),NULL };
OK, this came from aac0e8ff (builtin/bugreport.c: create '--diagnose' option, 2022-08-12), which gets the SYNOPSIS in the documentation right but misses the usage text.
An identical fix already exists as 63407051 (doc txt & -h
consistency: add missing "]" to bugreport "-h", 2022-09-05).
It may help the project more to help move the topic that contains it forward by reviewing them, than independently coming up with an identical fix. The topic with the existing fix appears at
https://lore.kernel.org/git/[email protected]/
Thanks.
Quoted 4 lines · Junio C Hamano
An identical fix already exists as 63407051 (doc txt & -h
consistency: add missing "]" to bugreport "-h", 2022-09-05).
Thanks for pointing this out. I'm sorry that I wasn't aware of the fix.
Quoted 7 lines
It may help the project more to help move the topic that contains it forward by reviewing them, than independently coming up with an identical fix. The topic with the existing fix appears at
https://lore.kernel.org/git/[email protected]/
Thanks.
I did a quick search on the mailing list webpage and didn't find anything immediately. Apologies for the noise.
I only work with l10n every once a few months, and I hope that is not too unhelpful when I submit minor patches of i18n text when I find issues.
Best and Have a nice weekend,
Fangyi