Skip to contentSkip to conversation

ls-files: fix black space in error message

PATCH In review ZheNing Hu via GitGitGadget 3 participants 3 messages Sep 11, 2022 – Sep 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ls-files: fix black space in error message

From: ZheNing Hu <[email protected]>

ce74de9(ls-files: introduce "--format" option) miss a space between two words incorrectly, it leads to wrong i10n messages. So fix it by adding a space at the end of the error message.

---
ls-files: fix black space in error message

This patch want fix a little typo error in builtin/ls-files.c, which pointed out by Jiang Xin in [1].

[1]:
https://lore.kernel.org/git/CANYiYbFGSfg+iFV1ovhCSxW0YQSpemKUN-sS+F0BHee7KD5arA@mail.gmail.com/.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1350%2Fadlternative%2Fzh%2Fls-file-format-error-mesage-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1350

 builtin/ls-files.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/ls-files.c +1 -1
index 779dc18e59d..4cf8a236483 100644
@@ -257,7 +257,7 @@ static size_t expand_show_index(struct strbuf *sb, const char *start,
 
 	end = strchr(start + 1, ')');
 	if (!end)
-		die(_("bad ls-files format: element '%s'"
+		die(_("bad ls-files format: element '%s' "
 		      "does not end in ')'"), start);
 
 	len = end - start + 1;

base-commit: dd3f6c4cae7e3b15ce984dce8593ff7569650e24

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 2 lines · ZheNing Hu via GitGitGadget

From: ZheNing Hu <[email protected]>
Subject: Re: [PATCH] ls-files: fix black space in error message

"black" -> "missing" perhaps? I'll queue with the reword for now but if you have a better alternative please holler.

Quoted 3 lines

ce74de9(ls-files: introduce "--format" option) miss a space between two words incorrectly, it leads to wrong i10n messages. So fix it by adding a space at the end of the error message.

Thanks.

#2 lore raw
Quoted 9 lines · Junio C Hamano <[email protected]> 于2022年9月13日周二 00:24写道:
Quoted 2 lines · ZheNing Hu via GitGitGadget

From: ZheNing Hu <[email protected]>
Subject: Re: [PATCH] ls-files: fix black space in error message

"black" -> "missing" perhaps? I'll queue with the reword for now but if you have a better alternative please holler.

Use the "missing" is ok, thanks,

Quoted 5 lines
Quoted 3 lines

ce74de9(ls-files: introduce "--format" option) miss a space between two words incorrectly, it leads to wrong i10n messages. So fix it by adding a space at the end of the error message.

Thanks.

ZheNing Hu