ci: use a newer `github-script` version
PATCH 1/1 ci: use a newer `github-script` version
From: Johannes Schindelin <[email protected]>
The old version we currently use runs in node.js v12.x, which is being deprecated in GitHub Actions. The new version uses node.js v16.x.
Incidentally, this also avoids the warning about the deprecated ::set-output:: workflow command because the newer version of the github-script Action uses the recommended new way to specify outputs.
---
ci: use a newer github-script version
I had a look at the CI run of seen a couple of weeks ago and saw not only quite a number of failures but also quite a number of warnings.
This patch addresses a few of them, including the ones about using the deprecated ::set-output:: workflow command
[https://github.com/gitgitgadget/git/actions/runs/3412982102/jobs/5679166059#step:4:46].
Similar warnings will be addressed by
od/ci-use-checkout-v3-when-applicable.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1387%2Fdscho%2Fupgrade-github-script-version-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1387/dscho/upgrade-github-script-version-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1387
.github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
.github/workflows/main.yml +3 -3
@@ -37,14 +37,14 @@ jobs: echo "::set-output name=enabled::$enabled" - name: skip if the commit or tree was already tested id: skip-if-redundant - uses: actions/github-script@v3 + uses: actions/github-script@v6 if: steps.check-ref.outputs.enabled == 'yes' with: github-token: ${{secrets.GITHUB_TOKEN}} script: | try { // Figure out workflow ID, commit and tree - const { data: run } = await github.actions.getWorkflowRun({ + const { data: run } = await github.rest.actions.getWorkflowRun({ owner: context.repo.owner, repo: context.repo.repo, run_id: context.runId,
@@ -54,7 +54,7 @@ jobs: const tree_id = run.head_commit.tree_id; // See whether there is a successful run for that commit or tree - const { data: runs } = await github.actions.listWorkflowRuns({ + const { data: runs } = await github.rest.actions.listWorkflowRuns({ owner: context.repo.owner, repo: context.repo.repo, per_page: 500,
base-commit: 4732897cf0a255a23dca9e97b65cea40cd06c5a8
Signature · 1 line
gitgitgadget
Quoted 8 lines · Johannes Schindelin via GitGitGadget
From: Johannes Schindelin <[email protected]>
The old version we currently use runs in node.js v12.x, which is being deprecated in GitHub Actions. The new version uses node.js v16.x.
Incidentally, this also avoids the warning about the deprecated
::set-output::workflow command because the newer version of thegithub-scriptAction uses the recommended new way to specify outputs.
Thanks for working on this.
I also appreciate you taking a more minimal approach by avoiding touching the explicit "echo ::set-output::"'s throughout the workflow definition, since there is other work going on there.
So let's merge this one down, let the dust settle on the other topic, and then come back and remove the remaining ::set-output::'s later on.
Thanks,
Taylor