Skip to contentSkip to conversation

i18n: mark more bundle.c strings for translation

PATCH In review D. Ben Knoble via GitGitGadget 2 participants 2 messages Jul 13, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i18n: mark more bundle.c strings for translation

From: "D. Ben Knoble" <[email protected]>

These two messages were introduced in 8ba221e245 (bundle: output hash information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse filter capability, 2022-03-09) but never for translation.

---
i18n: mark more bundle.c strings for translation

I noticed that git bundle output contained some untranslated messages for LC_ALL=fr_FR.UTF-8; in order to add translations for these messages, they need to be marked for translation.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1550%2Fbenknoble%2Fbundle-translations-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1550/benknoble/bundle-translations-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1550

 bundle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
bundle.c +2 -2
index 8d5936c4212..a9744da255c 100644
@@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,
 			list_refs(r, 0, NULL);
 		}
 
-		printf_ln("The bundle uses this hash algorithm: %s",
+		printf_ln(_("The bundle uses this hash algorithm: %s"),
 			  header->hash_algo->name);
 		if (header->filter.choice)
-			printf_ln("The bundle uses this filter: %s",
+			printf_ln(_("The bundle uses this filter: %s"),
 				  list_objects_filter_spec(&header->filter));
 	}
 cleanup:

base-commit: aa9166bcc0ba654fc21f198a30647ec087f733ed

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 5 lines · D. Ben Knoble via GitGitGadget

From: "D. Ben Knoble" <[email protected]>

These two messages were introduced in 8ba221e245 (bundle: output hash information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse filter capability, 2022-03-09) but never for translation.

Thanks for catching and reporting.

Quoted 5 lines
bundle.c +0 -0
index 8d5936c4212..a9744da255c 100644

bundle.c int verify_bundle(struct repository *r, · line 278

Quoted 10 lines
bundle.c +2 -2
@@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,
 			list_refs(r, 0, NULL);
 		}
 
-		printf_ln("The bundle uses this hash algorithm: %s",
+		printf_ln(_("The bundle uses this hash algorithm: %s"),
 			  header->hash_algo->name);
 		if (header->filter.choice)
-			printf_ln("The bundle uses this filter: %s",
+			printf_ln(_("The bundle uses this filter: %s"),
 				  list_objects_filter_spec(&header->filter));

Looking good. Will queue.

Thanks.