Skip to contentSkip to conversation

t0040: declare non-tab indentation to be okay in this script

PATCH In review Johannes Schindelin via GitGitGadget 2 participants 2 messages Aug 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t0040: declare non-tab indentation to be okay in this script

From: Johannes Schindelin <[email protected]>

By necessity, this script needs to verify that certain Git output matches expectations, including text indented with spaces instead of tabs.

Most recently, such a check was introduced in 448abbba6347 (short help:
allow multi-line opthelp, 2023-07-18) which is reported by git diff --check 448abbba6347^! as having whitespace issues.

Let's not complain about this because it is intentional.

---
t0040: declare non-tab indentation to be okay in this script

When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the Pull Request's check-whitespace run failed. Let's prevent having future contributors from also running into this type of issue when modifying t0040.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1568%2Fdscho%2Fsuppress-t0040-whitespace-error-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1568/dscho/suppress-t0040-whitespace-error-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1568

 t/.gitattributes | 1 +
 1 file changed, 1 insertion(+)
t/.gitattributes +1 -0
index 9930e283512..b9cea1795d8 100644
@@ -22,3 +22,4 @@ t[0-9][0-9][0-9][0-9]/* -whitespace
 /t7500/* eol=lf
 /t8005/*.txt eol=lf
 /t9*/*.dump eol=lf
+/t0040*.sh whitespace=-indent-with-non-tab

base-commit: 448abbba63471153df6ba520a5621595557ce3c8

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 7 lines · Johannes Schindelin via GitGitGadget

---
t0040: declare non-tab indentation to be okay in this script

When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the Pull Request's check-whitespace run failed. Let's prevent having future contributors from also running into this type of issue when modifying t0040.

Thanks for hardening these up. This looks obviously correct to me!

Thanks,
Taylor