Skip to contentSkip to conversation

merge-tree: fix argument type of the `--merge-base` option

PATCH In review Johannes Schindelin via GitGitGadget 2 participants 2 messages Apr 12, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 merge-tree: fix argument type of the `--merge-base` option

From: Johannes Schindelin <[email protected]>

In 5f43cf5b2e4 (merge-tree: accept 3 trees as arguments, 2024-01-28), I taught git merge-tree to perform three-way merges on trees. This commit even changed the manual page to state that the --merge-base option takes a tree-ish rather than requiring a commit.

But I forgot to adjust the in-program help text. This patch fixes that.

---
merge-tree: adjust argument type of the --merge-base option

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1717%2Fdscho%2Fmerge-tree-document-merge-base-treeish-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1717/dscho/merge-tree-document-merge-base-treeish-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1717

 builtin/merge-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/merge-tree.c +1 -1
index 3492a575a6c..60eaf0ca9f1 100644
@@ -563,7 +563,7 @@ int cmd_merge_tree(int argc, const char **argv, const char *prefix)
 			   PARSE_OPT_NONEG),
 		OPT_STRING(0, "merge-base",
 			   &merge_base,
-			   N_("commit"),
+			   N_("tree-ish"),
 			   N_("specify a merge-base for the merge")),
 		OPT_STRVEC('X', "strategy-option", &xopts, N_("option=value"),
 			N_("option for selected merge strategy")),

base-commit: 342990c7aaef5ac645e89101cb84569caf64baf4

Signature · 1 line
gitgitgadget
#1 lore raw

"Johannes Schindelin via GitGitGadget" <[email protected]>

Quoted 8 lines · writes:

From: Johannes Schindelin <[email protected]>

In 5f43cf5b2e4 (merge-tree: accept 3 trees as arguments, 2024-01-28), I taught git merge-tree to perform three-way merges on trees. This commit even changed the manual page to state that the --merge-base option takes a tree-ish rather than requiring a commit.

But I forgot to adjust the in-program help text. This patch fixes that.

Thanks for being careful---better late than never ;-)

Will queue and fast-track, as I do not see much chance of regression coming from here.

Quoted 27 lines

---
merge-tree: adjust argument type of the --merge-base option

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1717%2Fdscho%2Fmerge-tree-document-merge-base-treeish-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1717/dscho/merge-tree-document-merge-base-treeish-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1717

 builtin/merge-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/merge-tree.c +1 -1
index 3492a575a6c..60eaf0ca9f1 100644
@@ -563,7 +563,7 @@ int cmd_merge_tree(int argc, const char **argv, const char *prefix)
 			   PARSE_OPT_NONEG),
 		OPT_STRING(0, "merge-base",
 			   &merge_base,
-			   N_("commit"),
+			   N_("tree-ish"),
 			   N_("specify a merge-base for the merge")),
 		OPT_STRVEC('X', "strategy-option", &xopts, N_("option=value"),
 			N_("option for selected merge strategy")),

base-commit: 342990c7aaef5ac645e89101cb84569caf64baf4