Skip to contentSkip to conversation

config.txt: add trailer.* variables

PATCH In review Julian Prein via GitGitGadget 4 participants 4 messages Jan 9, 2025 – Jan 24, 2025 Documentation

lore
Share & tools
lore

Julian Prein via GitGitGadget

author
#0 lore raw

PATCH 1/1 config.txt: add trailer.* variables

From: Julian Prein <[email protected]>

The trailer.* configuration variables are currently only described in git-interpret-trailers(1) but affect git-commit and git-tag as well. Move that section into its own config/trailer.txt file and also include it in git-config(1).

Signed-off-by Julian Prein <[email protected]>

---
config.txt: add trailer.* variables

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1871%2Fdruckdev%2Ftrailer-config-vars-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1871/druckdev/trailer-config-vars-v1
Pull-Request: https://github.com/git/git/pull/1871

 Documentation/config.txt                 |   2 +
 Documentation/config/trailer.txt         | 136 ++++++++++++++++++++++
 Documentation/git-interpret-trailers.txt | 137 +----------------------
 3 files changed, 140 insertions(+), 135 deletions(-)
 create mode 100644 Documentation/config/trailer.txt
Documentation/config.txt +2 -0
index 8c0b3ed8075..1b86323ca3f 100644
@@ -540,6 +540,8 @@ include::config/tar.txt[]
 
 include::config/trace2.txt[]
 
+include::config/trailer.txt[]
+
 include::config/transfer.txt[]
 
 include::config/uploadarchive.txt[]
Documentation/config/trailer.txt new file +136 -0

136 lines not on this page · raw message

Documentation/git-interpret-trailers.txt +2 -135

144 lines not on this page · raw message

base-commit: a60673e9252b08d4eca90543b3729f4798b9aafd

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 11 lines · Julian Prein via GitGitGadget

From: Julian Prein <[email protected]>

The trailer.* configuration variables are currently only described in git-interpret-trailers(1) but affect git-commit and git-tag as well. Move that section into its own config/trailer.txt file and also include it in git-config(1).

Signed-off-by Julian Prein <[email protected]>

---
config.txt: add trailer.* variables

Quoted 8 lines

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1871%2Fdruckdev%2Ftrailer-config-vars-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1871/druckdev/trailer-config-vars-v1
Pull-Request: https://github.com/git/git/pull/1871

 Documentation/config.txt                 |   2 +
 Documentation/config/trailer.txt         | 136 ++++++++++++++++++++++
 Documentation/git-interpret-trailers.txt | 137 +----------------------
 3 files changed, 140 insertions(+), 135 deletions(-)

Hello,

since it has been two weeks now in which this didn't get any feedback, I fear that it might have been lost in the void and thus wanted to bump the thread and kindly ask if someone could take a look at this.

I am also aware that a patch to the documentation is probably very low priority, so please tell me for the future if I'm too impatient with this and should have waited a bit longer.

Thanks,
Julian

#2 lore raw
In reply to Julian Prein via GitGitGadget
Quoted 4 lines · Julian Prein via GitGitGadget

The trailer.* configuration variables are currently only described in git-interpret-trailers(1) but affect git-commit and git-tag as well. Move that section into its own config/trailer.txt file and also include it in git-config(1).

Makes sense. git-commit.txt and git-tag.txt do indeed reference these variables, and one would expect them to be mentioned by Documentation/config.txt, as well.

Documentation/config.txt include::config/tar.txt[] · line 544

Quoted 9 lines
Signed-off-by Julian Prein <[email protected]>

---

Documentation/config.txt +2 -0
@@ -540,6 +540,8 @@ include::config/tar.txt[]
 include::config/trace2.txt[]
 
+include::config/trailer.txt[]
+
 include::config/transfer.txt[]

Nice to see that you maintained alphabetical ordering here[*].

[*]: 5f78d52dce (docs: sort configuration variable groupings alphabetically, 2024-02-29)

#3 lore raw
Quoted 17 lines · Eric Sunshine
Quoted 4 lines · Julian Prein via GitGitGadget

The trailer.* configuration variables are currently only described in git-interpret-trailers(1) but affect git-commit and git-tag as well. Move that section into its own config/trailer.txt file and also include it in git-config(1).

Makes sense. git-commit.txt and git-tag.txt do indeed reference these variables, and one would expect them to be mentioned by Documentation/config.txt, as well.

Quoted 6 lines
Signed-off-by Julian Prein <[email protected]>

---

Documentation/config.txt +0 -0
@@ -540,6 +540,8 @@ include::config/tar.txt[]
 include::config/trace2.txt[]
Quoted 8 lines

Documentation/config.txt include::config/tar.txt[] · line 545

Quoted 3 lines
Documentation/config.txt +2 -0
+include::config/trailer.txt[]
+
 include::config/transfer.txt[]

Nice to see that you maintained alphabetical ordering here[*].

[*]: 5f78d52dce (docs: sort configuration variable groupings alphabetically, 2024-02-29)

Thanks for reviewing carefully.