Skip to contentSkip to conversation

merge-base, ls-remote, ls-tree: fix error message formatting

PATCH New Md Ferdous Alam via GitGitGadget 1 participant 1 message Feb 23

lore
Share & tools
lore

Md Ferdous Alam via GitGitGadget

author
#0 lore raw

PATCH 1/1 merge-base, ls-remote, ls-tree: fix error message formatting

From: mdferdousalam <[email protected]>

The CodingGuidelines state that error messages should not begin with a capital letter and should not end with a full stop. Fix the die() messages in builtin/merge-base.c, builtin/ls-remote.c, and builtin/ls-tree.c that violate these rules.

Signed-off-by mdferdousalam <[email protected]>

---
merge-base, ls-remote, ls-tree: fix error message formatting

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2053%2Fmdferdousalam%2Ffix-error-messages-misc-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2053/mdferdousalam/fix-error-messages-misc-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2053

 builtin/ls-remote.c  | 2 +-
 builtin/ls-tree.c    | 2 +-
 builtin/merge-base.c | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
builtin/ls-remote.c +1 -1
index fe77829557..51d7579ca1 100644
@@ -128,7 +128,7 @@ int cmd_ls_remote(int argc,
 	if (!remote) {
 		if (dest)
 			die("bad repository '%s'", dest);
-		die("No remote configured to list refs from.");
+		die("no remote configured to list refs from");
 	}
 
 	if (get_url) {
builtin/ls-tree.c +1 -1
index 113e4a960d..7670aa77a3 100644
@@ -406,7 +406,7 @@ int cmd_ls_tree(int argc,
 		usage_with_options(ls_tree_usage, ls_tree_options);
 	if (repo_get_oid_with_flags(the_repository, argv[0], &oid,
 				    GET_OID_HASH_ANY))
-		die("Not a valid object name %s", argv[0]);
+		die("not a valid object name %s", argv[0]);
 
 	/*
 	 * show_recursive() rolls its own matching code and is
builtin/merge-base.c +3 -3
index c7ee97fa6a..e337f283f7 100644
@@ -47,10 +47,10 @@ static struct commit *get_commit_reference(const char *arg)
 	struct commit *r;
 
 	if (repo_get_oid(the_repository, arg, &revkey))
-		die("Not a valid object name %s", arg);
+		die("not a valid object name %s", arg);
 	r = lookup_commit_reference(the_repository, &revkey);
 	if (!r)
-		die("Not a valid commit name %s", arg);
+		die("not a valid commit name %s", arg);
 
 	return r;
 }

@@ -131,7 +131,7 @@ static int handle_fork_point(int argc, const char **argv)
 
 	commitname = (argc == 2) ? argv[1] : "HEAD";
 	if (repo_get_oid(the_repository, commitname, &oid))
-		die("Not a valid object name: '%s'", commitname);
+		die("not a valid object name: '%s'", commitname);
 
 	derived = lookup_commit_reference(the_repository, &oid);

base-commit: 7c02d39fc2ed2702223c7674f73150d9a7e61ba4

Signature · 1 line
gitgitgadget