t2107: modernize path existence check

PATCH Superseded QUANTUM via GitGitGadget 4 participants 9 messages Mar 18 – Mar 19 1 message not in the archive

lore

Share & tools

lore

QUANTUM via GitGitGadget

author

2026-03-18 18:12 UTC #0 lore raw

PATCH 1/1 t2107: modernize path existence check

From: Aditya <[email protected]>

Replace '! test -f' with 'test_path_is_missing' for better debugging information when the assertion fails.

Found using: git grep "test -[efd]" t/t????-*.sh

Signed-off-by Aditya <[email protected]>

---
[GSoC] t2107: modernize path existence check

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2071

 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

t/t2107-update-index-basic.sh +1 -1

index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '

base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71

Signature · 1 line

gitgitgadget

Junio C Hamano

2026-03-18 18:51 UTC #1 lore raw

Quoted 4 lines · QUANTUM via GitGitGadget

From: Aditya <[email protected]>
Replace '! test -f' with 'test_path_is_missing' for better debugging information when the assertion fails.

OK.

Quoted 1 line

Found using: git grep "test -[efd]" t/t????-*.sh

People seem to add the above to their test-path helper patches, but unless the coverage of the work is fairly thorough and you want to say "all the similar issues should be found with this command and I addressed all of them", I do not see much point saying how you found one of them and addressed it.

Quoted 27 lines

Signed-off-by Aditya <[email protected]>
---
[GSoC] t2107: modernize path existence check
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2071
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2107-update-index-basic.sh +1 -1
index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '
 
base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71

Pablo

2026-03-18 19:03 UTC #2 lore raw

Quoted 10 lines · Junio C Hamano

Quoted 4 lines · QUANTUM via GitGitGadget
From: Aditya <[email protected]>
Replace '! test -f' with 'test_path_is_missing' for better debugging information when the assertion fails.
OK.

Quoted 7 lines

Quoted 1 line
Found using: git grep "test -[efd]" t/t????-*.sh
People seem to add the above to their test-path helper patches, but unless the coverage of the work is fairly thorough and you want to say "all the similar issues should be found with this command and I addressed all of them", I do not see much point saying how you found one of them and addressed it.

I think it is because of how it is explained on Ideas for microprojects [1]. It is written:

Steps to Complete

Find a test script using old-style path checks:

git grep "test -[efd]" t/

and later says "Include which command you used to find the instances in your commit message"

[1]: https://git.github.io/SoC-2026-Microprojects/ "Ideas for microprojects"

Quoted 29 lines

Quoted 28 lines
Signed-off-by Aditya <[email protected]>
---
[GSoC] t2107: modernize path existence check
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2071
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2107-update-index-basic.sh +1 -1
index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
      # the_index.cache_changed is zero, rollback_lock_file fails
      git update-index --refresh --verbose >out &&
      test_must_be_empty out &&
-     ! test -f .git/index.lock
+     test_path_is_missing .git/index.lock
      )
 '
 
base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71

Aditya Indora

2026-03-18 20:05 UTC #3 lore raw

Quoted 5 lines · Junio C Hamano

People seem to add the above to their test-path helper patches, but unless the coverage of the work is fairly thorough and you want to say "all the similar issues should be found with this command and I addressed all of them", I do not see much point saying how you found one of them and addressed it.

Understood. Will remove in v2.

Quoted 2 lines · Pablo

This seems fine but it could add more about why it is better, something like: by reporting loudly what expectation was not met.

Good point. Will expand the description in v2.

Quoted 2 lines

I think it is because of how it is explained on Ideas for microprojects [1].

Yes, that was the reason. Thanks for pointing it out.

Pablo

2026-03-18 18:58 UTC #4 lore raw

In reply to QUANTUM via GitGitGadget

Quoted 2 lines · Aditya

Replace '! test -f' with 'test_path_is_missing' for better debugging information when the assertion fails.

This seems fine but it could add more about why it is better, something like: by reporting loudly what expectation was not met. Also, If this is for GSoC when submitting the patches or anything relevant to GSoC contributions add to the prefix with PATCH something
like: [GSoC PATCH] and CC your possible co-mentors. Read [1].

Quoted 1 line

Found using: git grep "test -[efd]" t/t????-*.sh

As Junio said in other microprojects reviews, including the search command it's not very useful when you only address one instance.

[1]: https://git.github.io/General-Microproject-Information/ "about microprojects information"

Quoted 16 lines

Signed-off-by Aditya <[email protected]>
---
[GSoC] t2107: modernize path existence check
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2071
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2107-update-index-basic.sh +0 -0
index cc72ead79f..3bffe5da8a 100755

t/t2107-update-index-basic.sh test_expect_success '.lock files cleaned up' ' · line 91

Quoted 7 lines

t/t2107-update-index-basic.sh +1 -1

@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
        # the_index.cache_changed is zero, rollback_lock_file fails
        git update-index --refresh --verbose >out &&
        test_must_be_empty out &&
-       ! test -f .git/index.lock
+       test_path_is_missing .git/index.lock
        )
 '

Looks fine to me.

Quoted 6 lines

base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71 --
gitgitgadget

QUANTUM via GitGitGadget

author

2026-03-18 20:07 UTC #5 lore raw

PATCH v2 1/1 t2107: modernize path existence check

In reply to QUANTUM via GitGitGadget

From: Aditya <[email protected]>

Replace '! test -f' with 'test_path_is_missing' to get better debugging information by reporting loudly what expectation was not met when the assertion fails.

Signed-off-by Aditya <[email protected]>

---
[GSoC PATCH] t2107: modernize path existence check

CC: Pablo Sabater [email protected], Christian Couder [email protected], Karthik Nayak [email protected], Justin Tobler [email protected], Ayush Chandekar [email protected], Siddharth Asthana [email protected]

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/2071

Range-diff vs v1:

1: 264040c6a8 ! 1: 6ed91f8d9b t2107: modernize path existence check
@@ Metadata
## Commit message ##
t2107: modernize path existence check

- Replace '! test -f' with 'test_path_is_missing' for better
- debugging information when the assertion fails.
-
- Found using: git grep "test -[efd]" t/t????-*.sh
+ Replace '! test -f' with 'test_path_is_missing' to get better
+ debugging information by reporting loudly what expectation was
+ not met when the assertion fails.

Signed-off-by Aditya <[email protected]>

+ ---
+ v2:
+ - remove "Found using" line
+ - expand description to mention reporting behavior

## t/t2107-update-index-basic.sh ##
@@ t/t2107-update-index-basic.sh: test_expect_success '.lock files cleaned up' '

v2:
- remove "Found using" line
- expand description to mention reporting behavior

---
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

t/t2107-update-index-basic.sh +1 -1

index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '

base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71

Signature · 1 line

gitgitgadget

Junio C Hamano

2026-03-18 20:13 UTC #6 lore raw

Quoted 8 lines · QUANTUM via GitGitGadget

From: Aditya <[email protected]>
Replace '! test -f' with 'test_path_is_missing' to get better debugging information by reporting loudly what expectation was not met when the assertion fails.
Signed-off-by Aditya <[email protected]>
---

So we've seen you identify yourself as quantum, aditya, and aditya indora; which one do you want to be known as to this community?

cf. Documentation/SubmittingPatches:[[dco/real-name]]

A message that is not in the archive (sent off-list or not yet received): CAP6n+1Uj6sd75ENFY8=7NtcOUehTjY86YQV9YOWgdOqfmFHYPw@mail.gmail.com

Aditya Indora

2026-03-19 05:35 UTC #8 lore raw

Quoted 4 lines · Junio C Hamano,

Quoted 3 lines
So we've seen you identify yourself as quantum, aditya, and aditya indora; which one do you want to be known as to this community?.

quantum is just my github username inspired from steins gate anime, my first name is aditya and last name is indora , i want to be known as aditya to this community .

Aditya Indora

2026-03-19 15:39 UTC #9 lore raw

Hi Junio,
I have submitted my patch v2, in this thread please tell if any other changes need to be made or is it being queued.
Thanks

Quoted 9 lines · Aditya Indora

Quoted 5 lines · Junio C Hamano,
Quoted 3 lines
So we've seen you identify yourself as quantum, aditya, and aditya indora; which one do you want to be known as to this community?.
quantum is just my github username inspired from steins gate anime, my first name is aditya and last name is indora , i want to be known as aditya to this community .