doc: define timestamp in pack protocol grammar
PATCH 1/1 doc: define timestamp in pack protocol grammar
From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?=
<[email protected]>
The grammar for depth-request uses 'timestamp' but never defines it, unlike 'depth' which is properly defined as '1*DIGIT'. Add the missing definition.
---
doc: define timestamp in pack protocol grammar
Fixes https://git.issues.gerritcodereview.com/issues/40000018
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1
Pull-Request: https://github.com/git/git/pull/2154
Documentation/gitprotocol-pack.adoc | 1 + 1 file changed, 1 insertion(+)
Documentation/gitprotocol-pack.adoc +1 -0
@@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line. additional-want = PKT-LINE("want" SP obj-id) depth = 1*DIGIT + timestamp = 1*DIGIT filter-request = PKT-LINE("filter" SP filter-spec) ----
base-commit: 68cb7f9e92a5d8e9824f5b52ac3d0a9d8f653dbe
Signature · 1 line
gitgitgadget
Quoted 2 lines · Heath Dutton🕴️ via GitGitGadget
From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?=
<[email protected]>
This name is expected to be identical to ...
Quoted 5 lines
The grammar for depth-request uses 'timestamp' but never defines it, unlike 'depth' which is properly defined as '1*DIGIT'. Add the missing definition.
Signed-off-by Heath Dutton <[email protected]>
... what we have here. There is something weird going on after the name before the e-mail on the in-body From: line, though?
Quoted 12 lines
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1
Pull-Request: https://github.com/git/git/pull/2154Documentation/gitprotocol-pack.adoc | 1 + 1 file changed, 1 insertion(+)Documentation/gitprotocol-pack.adoc +0
-0
Documentation/gitprotocol-pack.adoc out of what the server said it could do with the first 'want' line. · line 276
Quoted 4 lines
Documentation/gitprotocol-pack.adoc +1
-0@@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line. additional-want = PKT-LINE("want" SP obj-id) depth = 1*DIGIT + timestamp = 1*DIGIT
OK.
It was added at 569e554b (upload-pack: add deepen-since to cut shallow repos based on time, 2016-06-12) by Duy for deepen-since which is parsed using parse_timestamp() that is a fancier name for strtoumax(), so 1*DIGIT sounds fine.
Thanks.