Skip to contentSkip to conversation

t/t2107-update-index-basic: use test_path_is_missing

PATCH In review Jayesh Daga via GitGitGadget 2 participants 2 messages Mar 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t/t2107-update-index-basic: use test_path_is_missing

From: jayesh0104 <[email protected]>

Replace a raw '! test -f' check with test_path_is_missing to use the standard test helper and improve consistency with other tests.

---
[GSoC]: t2107-refs-tests: drop '-f' from test_path_is_missing

High-level (Intent & Context)
=============================

The test script t/pack-refs-tests.sh has two issues that prevent it from running correctly.

It uses: ! test -f .git/index.lock

This is inconsistent with the Git test framework, where helper functions such as test_path_is_missing should be used instead of raw test checks.

Low-level (Implementation & Justification)
==========================================

Without sourcing test-lib.sh, the test framework is not initialized, leading to errors such as: test_expect_success: not found

Replaced raw file check with the appropriate helper:

- ! test -f .git/index.lock
+ test_path_is_missing .git/index.lock

Summary
=======

Replace test_path_is_missing .git/index.lock

cc Karthik Nayak [email protected]

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2250%2Fjayesh0104%2Ft2107-missing-helper-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2250/jayesh0104/t2107-missing-helper-v1
Pull-Request: https://github.com/git/git/pull/2250

 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2107-update-index-basic.sh +1 -1
index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '
 

base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 1 line · Jayesh Daga via GitGitGadget

From: jayesh0104 <[email protected]>

The author identifier (name and email) used here to identify the author must match the identifier used to sign-off. You'd probably need to "git commit --amend --reset-author" this commit with updatec user.name set to "Jayesh Daga", not "jayesh0104" or something.

Quoted 25 lines

Replace a raw '! test -f' check with test_path_is_missing to use the standard test helper and improve consistency with other tests.

---
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2107-update-index-basic.sh +1 -1
index cc72ead79f..3bffe5da8a 100755
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '
 

base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad