t0081: modernize the code testing whether a file exists

From: Shashank <[email protected]>

Replace the old-style shell test -f command with Git's modern test_path_is_file.

This instance was found using:
`git grep "test -[efd]" t/'

Signed-off-by Shashank <[email protected]>

---
[outreachy] t0081: Replace the old style 'test -f' to new 'test_path_is_file'

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2254%2Fshashu8660%2Fupdate-t0081-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2254/shashu8660/update-t0081-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2254

 t/t0081-find-pack.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

t/t0081-find-pack.sh +0 -0

index ff9d56fbf1..7d5082c487 100755

t/t0081-find-pack.sh +0 -0

        # Everything is in the same pack
        test "$head_commit_pack" = "$head_tree_pack" &&
 

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd --
gitgitgadget

Quoted 7 lines

From: Shashank <[email protected]>

Replace the old-style shell test -f command with Git's modern test_path_is_file.

This instance was found using:
`git grep "test -[efd]" t/'

This is not necessary, remove it.

Quoted 1 line · Usman Akinyemi

Quoted 1 line

From: Shashank <[email protected]>

Since many candidates are working on similar microprojects (which is fine) and making the same mistakes (which is expected), perhaps mentors should tell them to read the review exchanges on other candidates' patches and learn from them, instead of or in addition to giving the same advice repeatedly.

Quoted 7 lines · Usman Akinyemi

Quoted 7 lines

From: Shashank <[email protected]>

Replace the old-style shell test -f command with Git's modern test_path_is_file.

This instance was found using:
`git grep "test -[efd]" t/'

Quoted 1 line

This is not necessary, remove it.

Since many candidates are working on similar microprojects (which is fine) and making the same mistakes (which is expected), perhaps mentors should tell them to read the review exchanges on other candidates' patches and learn from them, instead of or in addition to giving the same advice repeatedly.

That said, I just wanted to highlight one thing. In the Microproject ideas page[1], we have the following for this specific idea:

Notes

- Start small: Pick a test file with just a few instances to convert
- Run the test suite after your changes to ensure nothing breaks
- Follow Git’s commit message style
- Include which command you used to find the instances in your commit message

So, we can't really blame the candidates for including the command in the commit message. It is our mistake asking them to include it in the first place when we don't prefer it to be present there.

I raised a PR to fix that:

   https://github.com/git/git.github.io/pull/875

Quoted 3 lines · Kaartic Sivaraam

I raised a PR to fix that:

    https://github.com/git/git.github.io/pull/875

I do not think your update is taking us in the right direction, though. Recommend to have it under three-dash lines instead, perhaps?

Got it. Does the following change read better?

links/mentoring/soc/SoC-2026-Microprojects.md +0 -0

index 41354b50..17519e2d 100644
@@ -49,8 +49,9 @@ with Git's dedicated test helpers like 

test_path_is_file.
- Start small: Pick a test file with just a few instances to convert
- Run the test suite after your changes to ensure nothing breaks
- Follow Git's commit message style
-- You _do not need to_ include the command you used to find the instances

Quoted 13 lines · Kaartic Sivaraam

Got it. Does the following change read better?

links/mentoring/soc/SoC-2026-Microprojects.md +0 -0

index 41354b50..17519e2d 100644
@@ -49,8 +49,9 @@ with Git's dedicated test helpers like

test_path_is_file.
- Start small: Pick a test file with just a few instances to convert
- Run the test suite after your changes to ensure nothing breaks
- Follow Git's commit message style
-- You _do not need to_ include the command you used to find the instances

links/mentoring/soc/SoC-2026-Microprojects.md with Git's dedicated test helpers like `test_path_is_file`. · line 54

Quoted 4 lines

links/mentoring/soc/SoC-2026-Microprojects.md +3 -1

-  in your commit message
+- You can include the command you used to find the instances in your
+  cover letter or between the three-dash line and the diffstat, whichever
+  is appropriate. Do not mention it in your commit message

Yes, this reads much better. It clearly guides contributors to put the command below the three-dash line or in the cover letter without cluttering the commit message.

Quoted 8 lines

From: Shashank <[email protected]>

Replace the old-style shell test -f command with Git's modern test_path_is_file.

This instance was found using:
`git grep "test -[efd]" t/'

This is not necessary, remove it.