Skip to contentSkip to conversation

t2403: modernize test for directory existence

PATCH In review Shashank S via GitGitGadget 3 participants 3 messages Oct 16 – Oct 23

lore
Share & tools
lore

Shashank S via GitGitGadget

author
#0 lore raw

PATCH 1/1 t2403: modernize test for directory existence

From: Shashank <[email protected]>

Replace the old-style shell test -d commands with Git's modern test_path_is_dir helper function.

This provides better debugging output if the tests were to fail, as the helper prints a clear error message rather than just failing silently like test -d does.

Signed-off-by Shashank <[email protected]>

---
[Outreachy PATCH] t2403: modernize test for directory existence

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2259%2Fshashu8660%2Foutreachy1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2259/shashu8660/outreachy1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2259

 t/t2403-worktree-move.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
t/t2403-worktree-move.sh +2 -2
index 69768c1207..85793f9460 100755
@@ -182,7 +182,7 @@ test_expect_success 'force remove worktree with untracked file' '
 
 test_expect_success 'remove missing worktree' '
 	git worktree add to-be-gone &&
-	test -d .git/worktrees/to-be-gone &&
+	test_path_is_dir .git/worktrees/to-be-gone &&
 	mv to-be-gone gone &&
 	git worktree remove to-be-gone &&
 	test_path_is_missing .git/worktrees/to-be-gone

@@ -191,7 +191,7 @@ test_expect_success 'remove missing worktree' '
 test_expect_success 'NOT remove missing-but-locked worktree' '
 	git worktree add gone-but-locked &&
 	git worktree lock gone-but-locked &&
-	test -d .git/worktrees/gone-but-locked &&
+	test_path_is_dir .git/worktrees/gone-but-locked &&
 	mv gone-but-locked really-gone-now &&
 	test_must_fail git worktree remove gone-but-locked &&
 	test_path_is_dir .git/worktrees/gone-but-locked

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd

Signature · 1 line
gitgitgadget
#2 lore raw
Quoted 6 lines · Usman Akinyemi
Quoted 2 lines

--
gitgitgadget

Looks good to me.

Thanks

Thanks, both. Queued.