bash-completion: add git-prune into bash completion
PATCH 1/1 bash-completion: add git-prune into bash completion
From: John Lin <[email protected]>
Sometimes git would suggest the user to run git prune when there are too many unreachable loose objects. It's more user-friendly if we add git-prune into bash completion.
---
bash-completion: add git-prune into bash completion
Sometimes git would suggest the user to run git prune when there are too many unreachable loose objects. It's more user-friendly if we add git-prune into bash completion.
Fixes #642.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-667%2Fjohnlinp%2Fadd-git-prune-bash-completion-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-667/johnlinp/add-git-prune-bash-completion-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/667
command-list.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
command-list.txt +1 -1
@@ -136,7 +136,7 @@ git-pack-redundant plumbinginterrogators git-pack-refs ancillarymanipulators git-parse-remote synchelpers git-patch-id purehelpers -git-prune ancillarymanipulators +git-prune ancillarymanipulators complete git-prune-packed plumbingmanipulators git-pull mainporcelain remote git-push mainporcelain remote
base-commit: 101b3204f37606972b40fc17dec84560c22f69f6
Signature · 1 line
gitgitgadget
Quoted 5 lines · John Lin via GitGitGadget
From: John Lin <[email protected]>
Sometimes git would suggest the user to run
git prunewhen there are too many unreachable loose objects. It's more user-friendly if we add git-prune into bash completion.
Yes, but it does not suggest all the time, and there is a reason. Most of the time "gc" is more appropriate, but there are narrow cases where "prune" is more appropriate and that is when the users will see suggestion to run "prune".
Isn't it too much to type p-r-u-n-e while seeing that message, typing as you read it?
I do not think it hurts to complete "git prune", in the sense that we would want to avoid completing potentially destructive operation to those who do not understand the implications, because the command is pretty much benign. But I am not sure it forces users to type too many keystrokes too frequently that it requires a tab completion. I dunno.
Will queue for now.
Thanks.
Hi Junio,
I saw this integrated into master. Thanks.
Best,
John Lin
Junio C Hamano <[email protected]> 於 2020年6月23日 週二 上午2:28寫道：
Quoted 27 lines
Quoted 5 lines · John Lin via GitGitGadget
From: John Lin <[email protected]>
Sometimes git would suggest the user to run
git prunewhen there are too many unreachable loose objects. It's more user-friendly if we add git-prune into bash completion.Yes, but it does not suggest all the time, and there is a reason. Most of the time "gc" is more appropriate, but there are narrow cases where "prune" is more appropriate and that is when the users will see suggestion to run "prune".
Isn't it too much to type p-r-u-n-e while seeing that message, typing as you read it?
I do not think it hurts to complete "git prune", in the sense that we would want to avoid completing potentially destructive operation to those who do not understand the implications, because the command is pretty much benign. But I am not sure it forces users to type too many keystrokes too frequently that it requires a tab completion. I dunno.
Will queue for now.
Thanks.
Quoted 3 lines · 林自均
Hi Junio,
I saw this integrated into master. Thanks.
Thank you for writing the patch.