Skip to contentSkip to conversation

githooks.txt: use correct "reference-transaction" hook name

PATCH In review starlord via GitGitGadget 3 participants 3 messages Jul 24, 2020 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 githooks.txt: use correct "reference-transaction" hook name

From: Bojun Chen <[email protected]>

The "reference transaction" hook was introduced in commit 6754159767 (refs: implement reference transaction hook, 2020-06-19). The name of the hook is declared as "reference-transaction" in "refs.c" and testcases, but the name declared in "githooks.txt" is different.

---
githooks.txt: use correct "reference-transaction" hook name

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/681

 Documentation/githooks.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/githooks.txt +2 -2
index 642471109f..31b601e4bc 100644
@@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
 `git send-pack` on the other end, so you can simply `echo` messages
 for the user.
 
-ref-transaction
-~~~~~~~~~~~~~~~
+reference-transaction
+~~~~~~~~~~~~~~~~~~~~~
 
 This hook is invoked by any Git command that performs reference
 updates. It executes whenever a reference transaction is prepared,

base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda

Signature · 1 line
gitgitgadget
Reviewed-by on v1 1/1
#1 lore raw

Hi Bojun,

Quoted 8 lines · starlord via GitGitGadget

From: Bojun Chen <[email protected]>

The "reference transaction" hook was introduced in commit 6754159767 (refs: implement reference transaction hook, 2020-06-19). The name of the hook is declared as "reference-transaction" in "refs.c" and testcases, but the name declared in "githooks.txt" is different.

Indeed, thanks for catching this!

Patrick

Quoted 29 lines

---
githooks.txt: use correct "reference-transaction" hook name

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/681

 Documentation/githooks.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/githooks.txt +2 -2
index 642471109f..31b601e4bc 100644
@@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
 `git send-pack` on the other end, so you can simply `echo` messages
 for the user.
 
-ref-transaction
-~~~~~~~~~~~~~~~
+reference-transaction
+~~~~~~~~~~~~~~~~~~~~~
 
 This hook is invoked by any Git command that performs reference
 updates. It executes whenever a reference transaction is prepared,

base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda

Signature · 1 line
gitgitgadget
#2 lore raw
Quoted 10 lines · Patrick Steinhardt

Hi Bojun,

Quoted 7 lines · starlord via GitGitGadget

From: Bojun Chen <[email protected]>

The "reference transaction" hook was introduced in commit 6754159767 (refs: implement reference transaction hook, 2020-06-19). The name of the hook is declared as "reference-transaction" in "refs.c" and testcases, but the name declared in "githooks.txt" is different.

Quoted 5 lines
Quoted 1 line

Indeed, thanks for catching this!

Thanks.