Skip to contentSkip to conversation

doc: fixed a typo in git-submodule.txt

PATCH In review thomas menzel via GitGitGadget 3 participants 5 messages Jan 6, 2020 Documentation

lore
Share & tools
lore
#0 lore raw

cover doc: fixed a typo in git-submodule.txt

fixed a typo in the doc of submodule

elonderin (1):
doc: submodule: fix typo for command absorbgitdirs

 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: 8679ef24ed64018bb62170c43ce73e0261c0600a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-688%2Felonderin%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-688/elonderin/patch-1-v1
Pull-Request: https://github.com/git/git/pull/688

Signature · 1 line
gitgitgadget
#1 lore raw

PATCH 1/1 doc: submodule: fix typo for command absorbgitdirs

From: elonderin <[email protected]>

The sentence wants to talk about the superproject's possesive, not plural form.

---
 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/git-submodule.txt +1 -1
index 22425cbc76..5232407f68 100644
@@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
 
 absorbgitdirs::
 	If a git directory of a submodule is inside the submodule,
-	move the git directory of the submodule into its superprojects
+	move the git directory of the submodule into its superproject's
 	`$GIT_DIR/modules` path and then connect the git directory and
 	its working directory by setting the `core.worktree` and adding
 	a .git file pointing to the git directory embedded in the
Signature · 1 line
gitgitgadget
#2 lore raw

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

Quoted 5 lines · elonderin via GitGitGadget

From: elonderin <[email protected]>

The sentence wants to talk about the superproject's possesive, not plural form.

The author of the patch must sign-off, so the above three lines should look more like so:

From: Thomas Menzel <[email protected]>

The sentence wants to talk about the superproject's possesive, not plural form.

From: Thomas Menzel <[email protected]>

The content of the patch obviously is correct.

Thanks.

Quoted 17 lines
---
 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/git-submodule.txt +1 -1
index 22425cbc76..5232407f68 100644
@@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
 
 absorbgitdirs::
 	If a git directory of a submodule is inside the submodule,
-	move the git directory of the submodule into its superprojects
+	move the git directory of the submodule into its superproject's
 	`$GIT_DIR/modules` path and then connect the git directory and
 	its working directory by setting the `core.worktree` and adding
 	a .git file pointing to the git directory embedded in the
#3 lore raw

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

In reply to elonderin via GitGitGadget

When anybody tries to respond to the quoted message [*1*] that came from GGG in the way recommended for the list, the *.noreply.github.com address gets placed on the Cc:, which is probably not wanted.

Can GGG do something about it? As GitHub specific service, it is not wrong for it to know what noreply.github.com means so dropping such an address from its Cc: line shouldn't be too difficult.

Thanks.

Reference *1*

<b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com>

Quoted 22 lines · elonderin via GitGitGadget

From: elonderin <[email protected]>

The sentence wants to talk about the superproject's possesive, not plural form.

---
 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/git-submodule.txt +1 -1
index 22425cbc76..5232407f68 100644
@@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
 
 absorbgitdirs::
 	If a git directory of a submodule is inside the submodule,
-	move the git directory of the submodule into its superprojects
+	move the git directory of the submodule into its superproject's
 	`$GIT_DIR/modules` path and then connect the git directory and
 	its working directory by setting the `core.worktree` and adding
 	a .git file pointing to the git directory embedded in the
#4 lore raw

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

Hi Junio,

Quoted 9 lines · Junio C Hamano

When anybody tries to respond to the quoted message [*1*] that came from GGG in the way recommended for the list, the *.noreply.github.com address gets placed on the Cc:, which is probably not wanted.

Can GGG do something about it? As GitHub specific service, it is not wrong for it to know what noreply.github.com means so dropping such an address from its Cc: line shouldn't be too difficult.

Quoted 6 lines

Thanks.

Reference *1*

<b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com>

Right. I added it to the bug tracker:
https://github.com/gitgitgadget/gitgitgadget/issues/182

Ciao,
Dscho