Skip to contentSkip to conversation

net-gre: clear skb->queue_mapping in GRE recv path

PATCH In review [email protected] 2 participants 2 messages Sep 24, 2010 – Sep 25, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net-gre: clear skb->queue_mapping in GRE recv path

From: chavey <[email protected]>
Date: Fri, 24 Sep 2010 15:05:02 -0700

A continuous stream of errors:

slbgre0 received packet on queue [123], but number of RX queues is 1
net_ratelimit: 155786 callbacks suppressed

is filling up /var/log/messages.

This is due to not unsetting skb->queue_mapping in the GRE receive path.

---
 net/ipv4/ip_gre.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/ip_gre.c +1 -0
index 945b20a..53bdb97 100644
@@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
 		}
 
 		skb_tunnel_rx(skb, tunnel->dev);
+		skb_set_queue_mapping(skb, 0);
 
 		skb_reset_network_header(skb);
 		ipgre_ecn_decapsulate(iph, skb);
Signature · 1 line
1.7.1
#1 lore raw
Quoted 22 lines · Le vendredi 24 septembre 2010 à 16:18 -0700, [email protected] a écrit :

From: chavey <[email protected]>
Date: Fri, 24 Sep 2010 15:05:02 -0700

A continuous stream of errors:

slbgre0 received packet on queue [123], but number of RX queues is 1
net_ratelimit: 155786 callbacks suppressed

is filling up /var/log/messages.

This is due to not unsetting skb->queue_mapping in the GRE receive path.

---
 net/ipv4/ip_gre.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/ip_gre.c +0 -0
index 945b20a..53bdb97 100644

net/ipv4/ip_gre.c static int ipgre_rcv(struct sk_buff *skb) · line 647

Quoted 7 lines
net/ipv4/ip_gre.c +1 -0
@@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
 		}
 
 		skb_tunnel_rx(skb, tunnel->dev);
+		skb_set_queue_mapping(skb, 0);
 
 		skb_reset_network_header(skb);
 		ipgre_ecn_decapsulate(iph, skb);

Laurent

Please use you full name in your signature,

Then, have you seen Tom Herbert patch yesterday ?

http://patchwork.ozlabs.org/patch/65583/

He suggested to place this skb_set_queue_mapping(skb, 0) inside skb_tunnel_rx(), so that we dont patch every tunnel driver ...

Thanks