Skip to contentSkip to conversation

hdspm.c: make driver name generic to avoid user confusion

PATCH Adrian Knoth 3 participants 5 messages Jun 7, 2011 – Jun 14, 2011 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 1 line · Jörn Nettingsmeier

hi adi, *!

Hi!

Review

Quoted 7 lines

here's a trivial patch to change the driver name of hdspm.c to avoid irritating users who don't have the MADI version (just happened on the LAU list).

static struct pci_driver driver = {

(quoted diff) +1 -1
-	.name = "RME Hammerfall DSP MADI",
+	.name = "RME Hammerfall HDSPe Series",

Are braces allowed in driver names? I guess so.

"HDSPe" is also confusing, only referring to the PCIe versions. Since we also support the old PCI versions, I suggest to name it

"RME Hammerfall HDSP(e) Series"

On the other hand, the 'H' in "HDSP" stands for "Hammerfall", so

"RME HDSP(e) Series"

would be more appropriate. Luckily, we don't collide with the hdsp.c driver name, but still, it's misleading, because there are cards that match "RME HDSP(e) Series" (like the Multiface/Digiface) but are handled by hdsp.c instead.

What at mess. ;) Merging hdsp.c into hdspm.c would be the clean approach to this problem, still I don't have time for this in the near future. Maybe in July.

Given that all current variants are misleading in one way or another, we could also leave everything as is. What do you think?

Cheers

Signature · 1 line
mail: [email protected]  	http://adi.thur.de	PGP/GPG: key via keyserver
#2 lore raw
Quoted 14 lines · Adrian Knoth

"HDSPe" is also confusing, only referring to the PCIe versions. Since we also support the old PCI versions, I suggest to name it

"RME Hammerfall HDSP(e) Series"

On the other hand, the 'H' in "HDSP" stands for "Hammerfall", so

"RME HDSP(e) Series"

would be more appropriate. Luckily, we don't collide with the hdsp.c driver name, but still, it's misleading, because there are cards that match "RME HDSP(e) Series" (like the Multiface/Digiface) but are handled by hdsp.c instead.

Quoted 7 lines

What at mess. ;) Merging hdsp.c into hdspm.c would be the clean approach to this problem, still I don't have time for this in the near future. Maybe in July.

Given that all current variants are misleading in one way or another, we could also leave everything as is. What do you think?

no. MADI is way too specific, and the only reason it's there is that winni started with just the MADI card...

enumerate supported cards? "RME HDSP AES32, AIO, RayDAT, MADI, MADIface" kludgy, but less potential for user confusion.

Signature · 7 lines
Jörn Nettingsmeier
Lortzingstr. 11, 45128 Essen, Tel. +49 177 7937487

Meister für Veranstaltungstechnik (Bühne/Studio)
Tonmeister (VDT)

http://stackingdwarves.net
#3 lore raw
In reply to Adrian Knoth

At Tue, 7 Jun 2011 11:11:32 +0200,

Quoted 22 lines · Adrian Knoth
Quoted 1 line · Jörn Nettingsmeier

hi adi, *!

Hi!

Review

Quoted 7 lines

here's a trivial patch to change the driver name of hdspm.c to avoid irritating users who don't have the MADI version (just happened on the LAU list).

static struct pci_driver driver = {

(quoted diff) +1 -1
-	.name = "RME Hammerfall DSP MADI",
+	.name = "RME Hammerfall HDSPe Series",

Are braces allowed in driver names? I guess so.

"HDSPe" is also confusing, only referring to the PCIe versions. Since we also support the old PCI versions, I suggest to name it

"RME Hammerfall HDSP(e) Series"

Quoted 8 lines

On the other hand, the 'H' in "HDSP" stands for "Hammerfall", so

"RME HDSP(e) Series"

would be more appropriate. Luckily, we don't collide with the hdsp.c driver name, but still, it's misleading, because there are cards that match "RME HDSP(e) Series" (like the Multiface/Digiface) but are handled by hdsp.c instead.

It's allowed but better to avoid, since this entry appears as a file name in /sys. We've chosen generic names for the pci name entries of sound drivers, but these look messy. Maybe we should choose just the module name as pci name.

thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#4 lore raw

At Tue, 07 Jun 2011 12:39:33 +0200,

Quoted 34 lines · Takashi Iwai

At Tue, 7 Jun 2011 11:11:32 +0200,

Quoted 22 lines · Adrian Knoth
Quoted 1 line · Jörn Nettingsmeier

hi adi, *!

Hi!

Review

Quoted 7 lines

here's a trivial patch to change the driver name of hdspm.c to avoid irritating users who don't have the MADI version (just happened on the LAU list).

static struct pci_driver driver = {

(quoted diff) +1 -1
-	.name = "RME Hammerfall DSP MADI",
+	.name = "RME Hammerfall HDSPe Series",

Are braces allowed in driver names? I guess so.

"HDSPe" is also confusing, only referring to the PCIe versions. Since we also support the old PCI versions, I suggest to name it

"RME Hammerfall HDSP(e) Series"

Quoted 8 lines

On the other hand, the 'H' in "HDSP" stands for "Hammerfall", so

"RME HDSP(e) Series"

would be more appropriate. Luckily, we don't collide with the hdsp.c driver name, but still, it's misleading, because there are cards that match "RME HDSP(e) Series" (like the Multiface/Digiface) but are handled by hdsp.c instead.

Quoted 4 lines

It's allowed but better to avoid, since this entry appears as a file name in /sys. We've chosen generic names for the pci name entries of sound drivers, but these look messy. Maybe we should choose just the module name as pci name.

Looking through the whole tree, the majority is to use the module name as pci_driver.name indeed. We should follow the convention, too.

So, Adrian, please don't take this to your patchset. I'm going to fix all sound/pci/* up once for 3.1 kernel.

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#5 lore raw
In reply to Takashi Iwai

At Tue, 07 Jun 2011 12:39:33 +0200,

Quoted 34 lines · Takashi Iwai

At Tue, 7 Jun 2011 11:11:32 +0200,

Quoted 22 lines · Adrian Knoth
Quoted 1 line · Jörn Nettingsmeier

hi adi, *!

Hi!

Review

Quoted 7 lines

here's a trivial patch to change the driver name of hdspm.c to avoid irritating users who don't have the MADI version (just happened on the LAU list).

static struct pci_driver driver = {

(quoted diff) +1 -1
-	.name = "RME Hammerfall DSP MADI",
+	.name = "RME Hammerfall HDSPe Series",

Are braces allowed in driver names? I guess so.

"HDSPe" is also confusing, only referring to the PCIe versions. Since we also support the old PCI versions, I suggest to name it

"RME Hammerfall HDSP(e) Series"

Quoted 8 lines

On the other hand, the 'H' in "HDSP" stands for "Hammerfall", so

"RME HDSP(e) Series"

would be more appropriate. Luckily, we don't collide with the hdsp.c driver name, but still, it's misleading, because there are cards that match "RME HDSP(e) Series" (like the Multiface/Digiface) but are handled by hdsp.c instead.

Quoted 4 lines

It's allowed but better to avoid, since this entry appears as a file name in /sys. We've chosen generic names for the pci name entries of sound drivers, but these look messy. Maybe we should choose just the module name as pci name.

OK, now I fixed the issues in all sound/pci/* drivers in sound git tree. Now they simply use KBUILD_MODNAME in the name field.

thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel