Fix the comparison with sizeof()
Subsystems (2)
PATCH 1/1 Fix the comparison with sizeof()
Fix the comparison with sizeof() in min() macro.
Signed-off-by Takashi Iwai <[email protected]>
---
drivers/scsi/aacraid/aachba.c +2 -2
@@ -1597,13 +1597,13 @@ int aac_scsi_cmd(struct scsi_cmnd * scsi cp[11 ] =0 ; cp[12 ] =0 ;aac_internal_transfer (scsicmd, cp,0 , -min ((unsigned int )scsicmd->cmnd[13 ],sizeof (cp))); +min ((size_t )scsicmd->cmnd[13 ],sizeof (cp)));if (sizeof (cp) < scsicmd->cmnd[13 ]) {unsigned int len, offset =sizeof (cp);memset (cp,0 , offset);do { - len =min (scsicmd->cmnd[13 ]-offset,sizeof (cp)); + len =min ((size_t )(scsicmd->cmnd[13 ]-offset),sizeof (cp));aac_internal_transfer (scsicmd, cp, offset, len); }while ((offset += len) < scsicmd->cmnd[13 ]); }
Quoted 3 lines · Takashi Iwai
-
min((unsigned int)scsicmd->cmnd[13], sizeof(cp)));
+min((size_t)scsicmd->cmnd[13], sizeof(cp)));
Note that this can also be done with the min_t() macro, although I can't immediately think of a reason why min_t() is any better..