Skip to contentSkip to conversation

hpimsgx: fix wrong sizeof

PATCH In review Axel Lin 2 participants 2 messages Jul 28, 2010 Sound

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 hpimsgx: fix wrong sizeof

The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS), sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect.

---
 sound/pci/asihpi/hpimsgx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/asihpi/hpimsgx.c +1 -1
index 2ee90dc..f01ab96 100644
@@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index)
 		hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM,
 			HPI_SUBSYS_FIND_ADAPTERS, 0);
 		memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr,
-			sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS));
+			sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS));
 
 		for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) {
 
Signature · 1 line
1.5.4.3
#1 lore raw

At Wed, 28 Jul 2010 16:58:42 +0800,

Quoted 5 lines · Axel Lin

The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS), sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect.

Applied now. Thanks.

Takashi

Quoted 22 lines
---
 sound/pci/asihpi/hpimsgx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/asihpi/hpimsgx.c +1 -1
index 2ee90dc..f01ab96 100644
@@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index)
 		hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM,
 			HPI_SUBSYS_FIND_ADAPTERS, 0);
 		memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr,
-			sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS));
+			sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS));
 
 		for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) {
 
Signature · 1 line
1.5.4.3