ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches
There's a mistake in this. The ID numbers are the wrong way round.
Alex
My mistake -- I didn't read your changelog properly. Sorry!
Quoted 3 lines · Alex Dewar
There's a mistake in this. The ID numbers are the wrong way round.
Alex
Quoted 2 lines · Alex Dewar
My mistake -- I didn't read your changelog properly. Sorry!
Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
thanks,
Takashi
Quoted 6 lines · Alex Dewar
Quoted 3 lines
There's a mistake in this. The ID numbers are the wrong way round.
Alex
I believe the code is correct (even though the diff is confusing), but I can edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand new submission in a new thread ?
Quoted 24 lines · Takashi Iwai
Quoted 2 lines · Alex Dewar
My mistake -- I didn't read your changelog properly. Sorry!
Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
thanks,
Takashi
Quoted 6 lines · Alex Dewar
Quoted 3 lines
There's a mistake in this. The ID numbers are the wrong way round.
Alex
Quoted 8 lines · Adrien Crivelli
[1 <text/plain; UTF-8 (7bit)>]
I believe the code is correct (even though the diff is confusing), but I can edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand new submission in a new thread ?
In a new thread please.
thanks,
Takashi
Quoted 27 lines · Takashi Iwai
On Mon, 24 Aug 2020 14:31:17 +0200,
Alex Dewar wrote:
>
> My mistake -- I didn't read your changelog properly. Sorry!Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
thanks,
Takashi
>
> On 24/08/2020 13:30, Alex Dewar wrote:
> > There's a mistake in this. The ID numbers are the wrong way round. > >
> > Alex
>
I just submitted the new patch.
Quoted 49 lines · Takashi Iwai
Quoted 4 lines · Adrien Crivelli
[1 <text/plain; UTF-8 (7bit)>]
I believe the code is correct (even though the diff is confusing), but I
can
Quoted 3 lines
edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand
new
Quoted 1 line
submission in a new thread ?
In a new thread please.
thanks,
Takashi
Quoted 15 lines · Takashi Iwai
On Mon, 24 Aug 2020 14:31:17 +0200,
Alex Dewar wrote:
>
> My mistake -- I didn't read your changelog properly. Sorry!Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
Quoted 7 lines
thanks,
Takashi
>
> On 24/08/2020 13:30, Alex Dewar wrote:
> > There's a mistake in this. The ID numbers are the wrong wayround.
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Alex